Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filter before user setttings context is rendered #46

Merged
merged 8 commits into from
Mar 1, 2023
Merged

feat: add filter before user setttings context is rendered #46

merged 8 commits into from
Mar 1, 2023

Conversation

Henrrypg
Copy link
Contributor

@Henrrypg Henrrypg commented Nov 15, 2022 •
edited by mariajgrimaldi
Loading

Description: This PR is to add one filter:

AccountSettingsRenderStarted filter which passes the account settings context before is rendered.

JIRA:
No direct openedx related ticket is available. Related tickets that add context to this change are:

Dependencies:

Merge deadline: List merge deadline (if any)

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

The example application using this filter is implemented in edunext-platoform and its PR contains the testing instructions.

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns: None

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 15, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 15, 2022 •
edited
Loading

Thanks for the pull request, @Henrrypg! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Henrrypg Henrrypg marked this pull request as draft November 15, 2022 23:29
This was referenced Nov 16, 2022
Merged
Merged
Closed
@Henrrypg Henrrypg marked this pull request as ready for review November 18, 2022 14:57
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Nov 21, 2022 •
edited
Loading

Hello! To contribute to this repo you'll have to sign a CLA first. cc @felipemontoya

@Henrrypg Henrrypg force-pushed the hpg/filters_registration_settings branch from 6a75bde to 510f87e Compare November 21, 2022 15:20
@Henrrypg Henrrypg marked this pull request as draft November 22, 2022 16:49
@Henrrypg Henrrypg force-pushed the hpg/filters_registration_settings branch 2 times, most recently from 9050e18 to 034f2b4 Compare November 30, 2022 17:42
@Henrrypg Henrrypg changed the title feat: add filters before registration and user setttings context feat: add filter before user setttings context is rendered Nov 30, 2022
@Henrrypg Henrrypg marked this pull request as ready for review November 30, 2022 17:43
@mariajgrimaldi mariajgrimaldi self-assigned this Dec 5, 2022
mariajgrimaldi
mariajgrimaldi requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for your contribution. Can you please fix the CI checks?

openedx_filters/learning/filters.py Outdated Show resolved Hide resolved
@Henrrypg Henrrypg force-pushed the hpg/filters_registration_settings branch from 131f0bc to 9133bc3 Compare December 5, 2022 14:32
@Henrrypg
Copy link
Contributor Author

Henrrypg commented Dec 5, 2022

Thank you @mariajgrimaldi, can you check with this changes?

@Henrrypg Henrrypg force-pushed the hpg/filters_registration_settings branch from 9133bc3 to 42eaef8 Compare December 5, 2022 21:07
@Henrrypg Henrrypg mentioned this pull request Dec 5, 2022
Merged
@Henrrypg Henrrypg force-pushed the hpg/filters_registration_settings branch from 42eaef8 to 1b72ef2 Compare December 7, 2022 17:12
@Henrrypg Henrrypg requested review from felipemontoya and mariajgrimaldi and removed request for mariajgrimaldi and felipemontoya December 7, 2022 17:13
@mphilbrick211
Copy link

Hi @Henrrypg - just checking to see if the requested changes were made and/or this pull request is ready for review. Thanks!

@mphilbrick211 mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 7, 2023
@Henrrypg
Copy link
Contributor Author

@mariajgrimaldi I just made your suggested minor changes and some changes with exceptions in favor of your suggestion

@mariajgrimaldi
Copy link
Member

I'll check on this again tomorrow!

@Henrrypg: can you rebase with main? Thanks!

@Henrrypg Henrrypg force-pushed the hpg/filters_registration_settings branch from 58a7551 to 5d17a34 Compare February 21, 2023 12:39
@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Feb 21, 2023
mariajgrimaldi
mariajgrimaldi approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for your patience and for following my suggestions!

@mariajgrimaldi
Copy link
Member

@Henrrypg: there are some issues with unittests. Can you help me fix them?

@Henrrypg
Copy link
Contributor Author

@mariajgrimaldi Of course, i'll work on this. Thank you!

@mphilbrick211 mphilbrick211 added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed changes requested needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Feb 22, 2023
@Henrrypg
Copy link
Contributor Author

@mariajgrimaldi @mphilbrick211 can you please re run tests? :D

@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Feb 27, 2023
@mariajgrimaldi
Copy link
Member

@Henrrypg: sorry to bother, can you add a changelog record for the filter? so we can release the library after emerging.

@mphilbrick211
Copy link

mphilbrick211 commented Feb 28, 2023 •
edited
Loading

Hi @mariajgrimaldi! When this is good-to-go, do you mind merging?

@Henrrypg
Copy link
Contributor Author

Henrrypg commented Mar 1, 2023

Hi @mphilbrick211 @mariajgrimaldi, i just commited the changelog and bump version

@mariajgrimaldi mariajgrimaldi merged commit 05f31c8 into openedx:main Mar 1, 2023
@openedx-webhooks
Copy link

@Henrrypg 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipemontoya felipemontoya felipemontoya approved these changes

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

Assignees

@mariajgrimaldi mariajgrimaldi

Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Henrrypg @openedx-webhooks @mariajgrimaldi @mphilbrick211 @felipemontoya @e0d