Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation according latest standards #49

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Nov 21, 2022

Description:
This PR updates the README file according to latest standards, including OEP-55.

Merge deadline:
ASAP

Installation instructions:
Just documentation.

Testing instructions:
Just documentation.

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

Author concerns:
how do we set readthedocs documentation?

@openedx-webhooks openedx-webhooks added core committer open-source-contribution PR author is not from Axim or 2U labels Nov 21, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @mariajgrimaldi!

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.

@mariajgrimaldi
Copy link
Member Author

@feanil: hello! 😄
As I mentioned in the PR concerns, how can we set readthedocs for this repo? (as it was for openedx-events)

@mariajgrimaldi mariajgrimaldi changed the title docs: update documentation according OEP-55 standards docs: update documentation according latest standards Nov 23, 2022
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor comments but they are non-blockers. Overall I think the docs change is great and the repo will be in a way better shape after the PR is merged.

Documentation
=============

See `documentation on Read the Docs <https://openedx-filters.readthedocs.io/en/latest/>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure that readthedocs is building. But maybe that can only happen after we merge the PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check Feanil's comment: #49 (comment)

README.rst Outdated Show resolved Hide resolved
@feanil
Copy link

feanil commented Nov 30, 2022

@mariajgrimaldi one of the things on my list for the next week or two is to write the doc that tells maintainers how they can get read the docs setup for their projects 🔁 . It looks like you don't need that to land the readme and changelog changes you have so far but I'll have that written soon and ping you on it so you can try it out here to setup sphinx docs in the way we want to standardize. We can do that as a follow-on task if that works for you?

Update: This is the ticket that will track that work if you want to follow along: openedx/docs.openedx.org#216

@mariajgrimaldi
Copy link
Member Author

@feanil: that works perfectly! Thank you.

@mariajgrimaldi mariajgrimaldi merged commit 753fb2f into main Dec 1, 2022
@mariajgrimaldi mariajgrimaldi deleted the MJG/oep-55-readme branch December 1, 2022 11:44
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@mariajgrimaldi mariajgrimaldi linked an issue Dec 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core committer open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update readme according OEP-55 specifications
4 participants