-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update documentation according latest standards #49
Conversation
Thanks for the pull request, @mariajgrimaldi! As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion. |
@feanil: hello! 😄 |
7dc3fdf
to
35c822b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few minor comments but they are non-blockers. Overall I think the docs change is great and the repo will be in a way better shape after the PR is merged.
Documentation | ||
============= | ||
|
||
See `documentation on Read the Docs <https://openedx-filters.readthedocs.io/en/latest/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure that readthedocs is building. But maybe that can only happen after we merge the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check Feanil's comment: #49 (comment)
@mariajgrimaldi one of the things on my list for the next week or two is to write the doc that tells maintainers how they can get read the docs setup for their projects 🔁 . It looks like you don't need that to land the readme and changelog changes you have so far but I'll have that written soon and ping you on it so you can try it out here to setup sphinx docs in the way we want to standardize. We can do that as a follow-on task if that works for you? Update: This is the ticket that will track that work if you want to follow along: openedx/docs.openedx.org#216 |
@feanil: that works perfectly! Thank you. |
@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
This PR updates the README file according to latest standards, including OEP-55.
Merge deadline:
ASAP
Installation instructions:
Just documentation.
Testing instructions:
Just documentation.
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns:
how do we set readthedocs documentation?