Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding codeowners file #83

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Adding codeowners file #83

merged 1 commit into from
Apr 27, 2023

Conversation

felipemontoya
Copy link
Member

Description: This PR adds a .github/CODEOWNERS file to bring the repo up to day with the maintainers program

Dependencies: None

Merge deadline: None, but hopefully soon

Installation instructions: None, it's all done by github

Testing instructions:

  1. Open a PR or an issue in this Repo
  2. The team @openedx/hooks-extension-framework should be tagged automatically

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • N/A Version bumped
  • Changelog record added
  • N/A Documentation updated (not only docstrings)
  • N/A Commits are squashed

Post merge:

  • N/A Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • N/A Delete working branch (if not needed anymore)

Author concerns: Given it is a simple PR that only changes the github process lightly I have no concerns

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 26, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @felipemontoya! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mariajgrimaldi mariajgrimaldi merged commit 5a326de into main Apr 27, 2023
@mariajgrimaldi mariajgrimaldi deleted the fmo/codeowners branch April 27, 2023 14:38
@openedx-webhooks
Copy link

@felipemontoya 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants