Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove frontend-lib-content-components from workflow [FC-0062] #7070

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

bradenmacdonald
Copy link
Contributor

We've moved frontend-lib-content-components into frontend-app-course-authoring, so we don't need to extract translations from content-components any more.

Related PR: openedx/frontend-app-authoring#1208

@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @committers-translations. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 29, 2024
@bradenmacdonald bradenmacdonald changed the title chore: remove frontend-lib-content-components from workflow chore: remove frontend-lib-content-components from workflow [FC-0062] Aug 29, 2024
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Aug 29, 2024
Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bradenmacdonald! Always a pleasure to review your PRs :)

Please also remove

# frontend-lib-content-components
- filter_type: file
file_format: KEYVALUEJSON
source_language: en
source_file: translations/frontend-lib-content-components/src/i18n/transifex_input.json
translation_files_expression: 'translations/frontend-lib-content-components/src/i18n/messages/<lang>.json'

Alsp remove to the actual resource translations (sorry for chaning my mind mid-way). Removing the actual resources won't break the Makefile scripting because it just ignores empty or missing files.

However, there's a ton of references for the frontend-lib-content-components that should be taken care of including a questionalbe reference in the communications app.

I hope you're aware of the rabbit hole. Nevertheless, thank you for taking the time to refactor.

@bradenmacdonald
Copy link
Contributor Author

@OmarIthawi Thanks - done!

Alsp remove to the actual resource translations (sorry for chaning my mind mid-way). Removing the actual resources won't break the Makefile scripting because it just ignores empty or missing files.

I'm not sure what you'd like me to do for this, sorry. Is that something to do in Transifex itself? If so I'm not sure if I even have permission.

However, there's a ton of references for the frontend-lib-content-components that should be taken care of including a questionalbe reference in the communications app.

Good point. I will open some more PRs to update those various references.

@OmarIthawi
Copy link
Member

I'm not sure what you'd like me to do for this, sorry. Is that something to do in Transifex itself? If so I'm not sure if I even have permission.

Appologies. Please remove this directory from the repository:

All of it, including both source strings and the translations.

@bradenmacdonald
Copy link
Contributor Author

Ah, gotcha. Done. Thanks for all the help, @OmarIthawi :)

Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @bradenmacdonald!

@OmarIthawi OmarIthawi merged commit f2154ea into openedx:main Aug 29, 2024
5 checks passed
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the remove-content-components branch August 30, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants