fix: add fixes after review

openedx · Oct 31, 2023 · ae63a66 · ae63a66
1 parent 4446978
commit ae63a66
Show file tree

Hide file tree

Showing 20 changed files with 40 additions and 21 deletions.
diff --git a/package.json b/package.json
@@ -41,7 +41,7 @@
     "example:start:with-theme": "npm run start:with-theme --workspace=example",
     "generate-changelog": "node generate-changelog.js",
     "i18n_compile": "formatjs compile-folder --format transifex ./src/i18n/messages ./src/i18n/messages",
-    "i18n_extract": "formatjs extract 'src/**/*.{jsx,js,tsx,ts}' --out-file ./src/i18n/transifex_input.json --format transifex",
+    "i18n_extract": "formatjs extract 'src/**/*.{jsx,js,tsx,ts}' --out-file ./src/i18n/transifex_input.json --ignore='**/*.d.ts' --format transifex",
     "type-check": "tsc --noEmit && tsc --project www --noEmit",
     "type-check:watch": "npm run type-check -- --watch",
     "build-types": "tsc --emitDeclarationOnly",

diff --git a/src/ProductTour/Checkpoint.jsx b/src/ProductTour/Checkpoint.jsx
@@ -98,8 +98,9 @@ const Checkpoint = React.forwardRef(({
     >
       <span className="sr-only">
         <FormattedMessage
-          id="pgn.checkpoint.sr-only.message"
-          defaultMessage={`Top of step ${index + 1}`}
+          id="pgn.ProductTour.Checkpoint.position-text"
+          defaultMessage="Top of step {step}"
+          value={{ step: index + 1 }}
           description="Screen-reader message to indicate the user's position in a sequence of checkpoints."
         />
       </span>

diff --git a/src/i18n/messages/ar.json b/src/i18n/messages/ar.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "رفع {filename} جارٍ.",
   "pgn.FormAutosuggest.iconButtonClosed": "إغلاق قائمة الخيارات",
   "pgn.FormAutosuggest.iconButtonOpened": "فتح قائمة الخيارات",
-  "pgn.Toast.closeLabel": "إغلاق "
+  "pgn.Toast.closeLabel": "إغلاق ",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/ca.json b/src/i18n/messages/ca.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Close"
+  "pgn.Toast.closeLabel": "Close",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/es_419.json b/src/i18n/messages/es_419.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Subiendo {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Cerrar el menú de opciones",
   "pgn.FormAutosuggest.iconButtonOpened": "Abre el menú de opciones",
-  "pgn.Toast.closeLabel": "Cerrar"
+  "pgn.Toast.closeLabel": "Cerrar",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/es_AR.json b/src/i18n/messages/es_AR.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Subiendo {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Cerrar el menú de opciones",
   "pgn.FormAutosuggest.iconButtonOpened": "Abre el menú de opciones",
-  "pgn.Toast.closeLabel": "Cerrar"
+  "pgn.Toast.closeLabel": "Cerrar",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/es_ES.json b/src/i18n/messages/es_ES.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Subiendo {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Cerrar el menú de opciones",
   "pgn.FormAutosuggest.iconButtonOpened": "Abre el menú de opciones",
-  "pgn.Toast.closeLabel": "Cerrar"
+  "pgn.Toast.closeLabel": "Cerrar",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/fr.json b/src/i18n/messages/fr.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Close"
+  "pgn.Toast.closeLabel": "Close",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/he.json b/src/i18n/messages/he.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Close"
+  "pgn.Toast.closeLabel": "Close",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/id.json b/src/i18n/messages/id.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Close"
+  "pgn.Toast.closeLabel": "Close",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/it_IT.json b/src/i18n/messages/it_IT.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Caricamento {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Chiudi"
+  "pgn.Toast.closeLabel": "Chiudi",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/ko_KR.json b/src/i18n/messages/ko_KR.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Close"
+  "pgn.Toast.closeLabel": "Close",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/pl.json b/src/i18n/messages/pl.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Zamknij"
+  "pgn.Toast.closeLabel": "Zamknij",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/pt_BR.json b/src/i18n/messages/pt_BR.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Close"
+  "pgn.Toast.closeLabel": "Close",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/pt_PT.json b/src/i18n/messages/pt_PT.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Carregando {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Fechar o menu de opções",
   "pgn.FormAutosuggest.iconButtonOpened": "Abrir o menu de opções",
-  "pgn.Toast.closeLabel": "Fechar"
+  "pgn.Toast.closeLabel": "Fechar",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/ru.json b/src/i18n/messages/ru.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Close"
+  "pgn.Toast.closeLabel": "Close",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/th.json b/src/i18n/messages/th.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Close"
+  "pgn.Toast.closeLabel": "Close",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/tr_TR.json b/src/i18n/messages/tr_TR.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "{filename} yükleniyor.",
   "pgn.FormAutosuggest.iconButtonClosed": "Seçenekler menüsünü kapat",
   "pgn.FormAutosuggest.iconButtonOpened": "Seçenekler menüsünü aç",
-  "pgn.Toast.closeLabel": "Kapat"
+  "pgn.Toast.closeLabel": "Kapat",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/uk.json b/src/i18n/messages/uk.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Close"
+  "pgn.Toast.closeLabel": "Close",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }
diff --git a/src/i18n/messages/zh_CN.json b/src/i18n/messages/zh_CN.json
@@ -27,5 +27,6 @@
   "pgn.Dropzone.UploadProgress.uploadLabel": "Uploading {filename}.",
   "pgn.FormAutosuggest.iconButtonClosed": "Close the options menu",
   "pgn.FormAutosuggest.iconButtonOpened": "Open the options menu",
-  "pgn.Toast.closeLabel": "Close"
+  "pgn.Toast.closeLabel": "Close",
+  "pgn.ProductTour.Checkpoint.position-text": "Top of step {step}"
 }