Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: fixed ModalDialog.Header sizes #2925

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Dec 12, 2023

Description

Issue: #2850

Deploy Preview

MadalDialog component

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Dec 12, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5cf6ceb
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/65799ad4d00d5c0008f0a29e
😎 Deploy Preview https://deploy-preview-2925--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90a19e0) 92.89% compared to head (5cf6ceb) 92.83%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2925      +/-   ##
==========================================
- Coverage   92.89%   92.83%   -0.07%     
==========================================
  Files         235      235              
  Lines        4338     4245      -93     
  Branches     1056     1032      -24     
==========================================
- Hits         4030     3941      -89     
+ Misses        304      300       -4     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fix-modal-dialog-header-sizes branch from 970f713 to 2695bd5 Compare December 12, 2023 12:23
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fix-modal-dialog-header-sizes branch from bf4b3f8 to 5cf6ceb Compare December 13, 2023 11:51
@viktorrusakov viktorrusakov merged commit 5af0b51 into openedx:master Dec 13, 2023
10 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 21.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 22.0.0-alpha.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

khudym pushed a commit to khudym/paragon that referenced this pull request Jan 2, 2024
* fix: fixed ModalDialog.Header sizes

* refactor: refactoring after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[paragon-openedx.netlify.app] ModalDialog.Header sizes are different for the default and color options
4 participants