Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: fixed ModalDialog.Header sizes #2925

Merged
merged 2 commits into from
Dec 13, 2023
Merged

[BD-46] fix: fixed ModalDialog.Header sizes #2925

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2695bd5
fix: fixed ModalDialog.Header sizes
PKulkoRaccoonGang Dec 12, 2023
5cf6ceb
refactor: refactoring after review
PKulkoRaccoonGang Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions src/Modal/_ModalDialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,18 @@
max-height: none;
margin: $modal-dialog-margin;
}

.pgn__modal-header {
padding-bottom: calc(#{$modal-inner-padding} / 2);
}

.pgn__modal-body {
padding: calc(#{$modal-inner-padding} / 2) $modal-inner-padding;

&::before {
top: calc(#{$modal-inner-padding} / 2 * -1);
}
}
}

// Sizes
Expand Down Expand Up @@ -230,22 +242,6 @@

// Color Variants

.pgn__modal-default {
// Default style modals don't have a background on the header which
// ends up looking spaced too far away from the body content.
.pgn__modal-header {
padding-bottom: calc(#{$modal-inner-padding} / 2);
}
viktorrusakov marked this conversation as resolved.
Show resolved Hide resolved

.pgn__modal-body {
padding: calc(#{$modal-inner-padding} / 2) $modal-inner-padding;

&::before {
top: calc(#{$modal-inner-padding} / 2 * -1);
}
}
}

.pgn__modal-dark {
.pgn__modal-header,
.pgn__modal-hero {
Expand All @@ -256,10 +252,6 @@
color: inherit;
}
}

.pgn__modal-header {
border-bottom: solid 1px $light;
}
}

.pgn__modal-warning .pgn__modal-header {
Expand Down