-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replaced bootstrap BaseCard component #3318
feat: Replaced bootstrap BaseCard component #3318
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #3318 +/- ##
==========================================
+ Coverage 93.82% 93.85% +0.03%
==========================================
Files 229 230 +1
Lines 3836 3857 +21
Branches 916 929 +13
==========================================
+ Hits 3599 3620 +21
Misses 230 230
Partials 7 7 ☔ View full report in Codecov by Sentry. |
01ef73a
to
c8e9ea4
Compare
c8e9ea4
to
f3beb20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my testing this seems to be working perfectly! Awesome job!
I made a PR pointing to this branch with the goal of adding typescript types #3320, if that looks good it'd be wonderful to land those together!
// @ts-ignore | ||
import CardBody from './CardBody'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to land this PR as-is and make a small issue for adding types to CardBody
that we can address in a follow-up PR
@adamstankiewicz thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a new issue for this change, let me know if you have anything to add
#3332
🎉 This PR is included in version 23.0.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Issue: #2484
Merge Checklist
example
app?Post-merge Checklist