chore: add typescript types for BaseCard
#3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Comment on lines
+7
to
8
| // @ts-ignore | ||
| import CardBody from './CardBody'; |
There was a problem hiding this comment.
If people are happy with this implementation for BaseCard I'd be more than happy to update CardBody in a similar manner so we don't need this @ts-ignore here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Peter_Kulko/remove-bootstrap-base-card #3320 +/- ##
==========================================================================
+ Coverage 93.84% 93.85% +0.01%
==========================================================================
Files 230 230
Lines 3849 3857 +8
Branches 927 899 -28
==========================================================================
+ Hits 3612 3620 +8
- Misses 230 233 +3
+ Partials 7 4 -3 ☔ View full report in Codecov by Sentry. |
brian-smith-tcril
force-pushed
the
basecard-typescript
branch
3 times, most recently
from
2a0f617 to
d68b2ff
Compare
PKulkoRaccoonGang
approved these changes
Dec 6, 2024
brian-smith-tcril
force-pushed
the
basecard-typescript
branch
from
d68b2ff to
f95bac1
Compare
PKulkoRaccoonGang
merged commit 9965409
into
openedx:Peter_Kulko/remove-bootstrap-base-card
6 checks passed
|
Great Job !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this does the trick for getting #3318 into
.tsxland