-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: removed white background on Stepper.Header component #2358
[BD-46] feat: removed white background on Stepper.Header component #2358
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
947d755
to
abef2d5
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2358 +/- ##
==========================================
+ Coverage 91.38% 91.40% +0.01%
==========================================
Files 234 234
Lines 4120 4129 +9
Branches 982 986 +4
==========================================
+ Hits 3765 3774 +9
Misses 348 348
Partials 7 7 ☔ View full report in Codecov by Sentry. |
src/Stepper/_variables.scss
Outdated
$stepper-header-step-list-margin: 0 !default; | ||
$stepper-header-active-step-bg: $gray-500 !default; | ||
$stepper-header-step-error-bubble-color: $danger !default; | ||
$stepper-header-step-error-bubble-box-shadow-color: $stepper-header-step-error-bubble-color !default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just use $stepper-header-step-error-bubble-color
since it is very complicated one. Although we want to reference as much as possible I think there should be a limit for depth. Otherwise it will be hard to override or to track where its origin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
src/Stepper/_variables.scss
Outdated
$stepper-header-active-step-bg: $gray-500 !default; | ||
$stepper-header-step-error-bubble-color: $danger !default; | ||
$stepper-header-step-error-bubble-box-shadow-color: $stepper-header-step-error-bubble-color !default; | ||
$stepper-header-step-error-bubble-box-shadow-width: 3px !default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reduce the name to 5 words max. In this case readability of variable is complicated, although the idea as I understand is to make it more clear what this value means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It`s interesting to think. Today we don't have special rules for naming SCSS variables. I agree with your idea about the unreadability of long names in SCSS variables. Unfortunately, in this case, I can't come up with a good combination for this variable (using 5 words). Would you happen to have any suggestions for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor with the addition of the _variables.scss
file :)
[question] Curious, will we need to create or do we already have these stepper SCSS variables as design tokens / CSS variables?
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Thanks @adamstankiewicz 👍 |
🎉 This PR is included in version 20.43.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Issue: #2342
Deploy Preview
Stepper component
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist