Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hyperlink button bug fix #2360

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix: hyperlink button bug fix #2360

merged 1 commit into from
Jun 6, 2023

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Jun 6, 2023

Description

Quick fix that allows buttons formatted as hyperlinks to be clickable.

[Adam] Additional context:

  • Demo of bug
  • When the href prop was added to the prop types for it to show up on the docs site, it needed a default prop of undefined. However, this made the <Button as={Hyperlink} destination="https://edx.org">Hello</Button> have no href in the DOM.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@kiram15 kiram15 requested a review from adamstankiewicz June 6, 2023 20:26
@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 2f099e5
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/647f999ba3ff85000782117f
😎 Deploy Preview https://deploy-preview-2360--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kiram15 kiram15 force-pushed the button-quickfix branch from a98ecdb to 2f099e5 Compare June 6, 2023 20:39
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4485a3c) 91.40% compared to head (2f099e5) 91.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2360   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files         234      234           
  Lines        4129     4129           
  Branches      986      986           
=======================================
  Hits         3774     3774           
  Misses        348      348           
  Partials        7        7           
Impacted Files Coverage Δ
src/Button/index.jsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiram15 kiram15 merged commit b9b5386 into master Jun 6, 2023
@kiram15 kiram15 deleted the button-quickfix branch June 6, 2023 21:06
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.43.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants