-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add defaults to theme-urls.json output on build #2468
Conversation
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🎉 This PR is included in version 21.0.0-alpha.40 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2468 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 214 214
Lines 3519 3519
Branches 852 852
=======================================
Hits 3223 3223
Misses 288 288
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Description
Extends
build-scss.js
Node.js script to include optional--defaultThemeVariants
option to customize the default theme variants to include in thetheme-urls.json
output.Ensures the
theme-urls.json
output looks like the following, with the additional of thedefaults
object property in favor of the previousdefault
anddark
properties:Deploy Preview
N/A
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist