Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color picker error message fix #2472

Merged
merged 3 commits into from
Aug 11, 2023
Merged

fix: color picker error message fix #2472

merged 3 commits into from
Aug 11, 2023

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Jul 24, 2023

Description

Quick style bug fix of error message of the ColorPicker component.
Screenshot 2023-07-24 at 4 13 41 PM
Screenshot 2023-07-24 at 4 11 03 PM

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@kiram15 kiram15 requested a review from adamstankiewicz July 24, 2023 22:15
@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 8ef3068
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64d47e53238edf0007377e08
😎 Deploy Preview https://deploy-preview-2472--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1a67d9b) 91.65% compared to head (8ef3068) 91.65%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2472   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         236      236           
  Lines        4195     4195           
  Branches     1012     1012           
=======================================
  Hits         3845     3845           
  Misses        346      346           
  Partials        4        4           
Files Changed Coverage Δ
src/ColorPicker/index.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ColorPicker/index.jsx Outdated Show resolved Hide resolved
src/ColorPicker/index.jsx Outdated Show resolved Hide resolved
@kiram15 kiram15 force-pushed the colorpicker-fix branch 2 times, most recently from 00ea08a to f911384 Compare August 9, 2023 21:01
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kiram15 kiram15 merged commit cbfb47f into master Aug 11, 2023
@kiram15 kiram15 deleted the colorpicker-fix branch August 11, 2023 15:05
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.46.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants