-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: added Segment track for CLI scripts #2617
Changes from 4 commits
222ab8d
cb9dcb8
e6ccd35
9787ccb
cae891e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
const axios = require('axios'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
|
||
/** | ||
* Sends request to the Netlify function to inform about specified event. | ||
* @param {string} eventId - tracking event id | ||
* @param {object} properties - tracking properties | ||
*/ | ||
function sendTrackInfo(eventId, properties) { | ||
const { BASE_URL, TRACK_ANONYMOUS_ANALYTICS } = process.env; | ||
if (TRACK_ANONYMOUS_ANALYTICS) { | ||
const url = `${BASE_URL}/.netlify/functions/sendTrackData`; | ||
axios.post(url, { eventId, properties }) | ||
.then(result => { | ||
// eslint-disable-next-line no-console | ||
console.log(`Track info is successfully sent (status ${result.status})`); | ||
}).catch(error => { | ||
// eslint-disable-next-line no-console | ||
console.log(`Track info request failed (${error})`); | ||
}); | ||
} | ||
} | ||
|
||
module.exports = { sendTrackInfo }; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
const { v4: uuidv4 } = require('uuid'); | ||
const Analytics = require('analytics-node'); | ||
|
||
const analytics = new Analytics(process.env.SEGMENT_KEY); | ||
|
||
exports.handler = async function eventHandler(event) { | ||
// Only allow POST | ||
if (event.httpMethod !== 'POST') { | ||
return { statusCode: 405, body: 'Method Not Allowed' }; | ||
} | ||
const { eventId, properties } = JSON.parse(event.body); | ||
// dispatch event to Segment | ||
analytics.track({ | ||
anonymousId: uuidv4(), | ||
event: eventId, | ||
properties, | ||
}); | ||
|
||
return { | ||
statusCode: 200, | ||
body: JSON.stringify({ success: true }), | ||
}; | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,12 @@ | ||
const { v4: uuidv4 } = require('uuid'); | ||
const Analytics = require('analytics-node'); | ||
|
||
const analytics = new Analytics(process.env.SEGMENT_KEY); | ||
const { handler: actualHandler } = require('./sendAnalyticsData'); | ||
|
||
exports.handler = async function eventHandler(event) { | ||
// Only allow POST | ||
if (event.httpMethod !== 'POST') { | ||
return { statusCode: 405, body: 'Method Not Allowed' }; | ||
} | ||
const { componentName } = JSON.parse(event.body); | ||
// dispatch event to Segment | ||
analytics.track({ | ||
anonymousId: uuidv4(), | ||
event: 'openedx.paragon.functions.track-generate-component.created', | ||
properties: { componentName }, | ||
const body = JSON.parse(event.body); | ||
event.body = JSON.stringify({ | ||
...body, | ||
eventId: 'openedx.paragon.functions.track-generate-component.created', | ||
properties: { componentName: body.componentName }, | ||
}); | ||
|
||
return { | ||
statusCode: 200, | ||
body: JSON.stringify({ success: true }), | ||
}; | ||
return actualHandler(event); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think it might be a good idea to add additional info about the command, for example if it succeeded or not. What do you think about moving this code into try / catch block below and sending status of execution?
Something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added, thanks