Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: add reverse prop to the stack component #2678

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

khudym
Copy link
Contributor

@khudym khudym commented Oct 2, 2023

Description

Add reverse prop to the Stack component
Issue

Deploy Preview

Deploy

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Oct 2, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @khudym!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 687e70a
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/652512d54a83850008b098da
😎 Deploy Preview https://deploy-preview-2678--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b67f77c) 91.83% compared to head (7e382dc) 91.83%.
Report is 14 commits behind head on master.

❗ Current head 7e382dc differs from pull request most recent head 687e70a. Consider uploading reports for the commit 687e70a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2678   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files         235      235           
  Lines        4224     4225    +1     
  Branches     1024     1025    +1     
=======================================
+ Hits         3879     3880    +1     
  Misses        341      341           
  Partials        4        4           
Files Coverage Δ
src/Stack/index.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov viktorrusakov linked an issue Oct 2, 2023 that may be closed by this pull request
Copy link
Contributor

@viktorrusakov viktorrusakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khudym Also, please add usage examples of new functionality to docs site.

src/Stack/index.jsx Outdated Show resolved Hide resolved
src/Stack/index.jsx Outdated Show resolved Hide resolved
@viktorrusakov viktorrusakov merged commit 10707c4 into openedx:master Oct 10, 2023
8 checks passed
@openedx-webhooks
Copy link

@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BD-46] Reverse values for the Stack directions
5 participants