-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: replace filter names with header names #2757
[BD-46] fix: replace filter names with header names #2757
Conversation
Thanks for the pull request, @khudym! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
1bf998e
to
bd345c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2757 +/- ##
=======================================
Coverage 92.82% 92.83%
=======================================
Files 235 235
Lines 4237 4240 +3
Branches 1029 1029
=======================================
+ Hits 3933 3936 +3
Misses 300 300
Partials 4 4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khudym @viktorrusakov @monteri Now, during filtering, we display the header of the list of elements by which it can be done. In the Filtered by... line we display exactly this title. Does it make sense to show the true title (list item) by which we are actually filtering? For example: "Filtered by brown taddy"
@PKulkoRaccoonGang I think it will be confusing if we filter by multiple columns when I close the filter tab in this case, I won't be able to understand |
@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Update DataTable's filter status bar's messaging by replacing the accessor with the header name
Issue
Deploy Preview
https://deploy-preview-2757--paragon-openedx.netlify.app/
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist