-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: Chip component redesign #2836
[BD-46] feat: Chip component redesign #2836
Conversation
refactor: added selected state refactor: added IconButton refactor: styles refactoring refactor: added tests refactor: added new SCSS variables
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
OLD PR: #2713 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/chip-searchfield-pagination #2836 +/- ##
=======================================================================
+ Coverage 92.83% 92.88% +0.05%
=======================================================================
Files 235 237 +2
Lines 4240 4270 +30
Branches 1029 1036 +7
=======================================================================
+ Hits 3936 3966 +30
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Appreciate your patience on the review :)
310480a
into
openedx:release/chip-searchfield-pagination
Description
Chip component redesign.
Issue: #2645
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist