Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: Chip component redesign #2836

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Nov 21, 2023

Description

Chip component redesign.

Issue: #2645

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 21, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 21, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title Peter kulko/chip redesign [BD-46] feat: Chip component redesign Nov 21, 2023
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Nov 21, 2023
@PKulkoRaccoonGang
Copy link
Contributor Author

PKulkoRaccoonGang commented Nov 21, 2023

OLD PR: #2713

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00c48ec) 92.83% compared to head (8fa7b1a) 92.88%.
Report is 21 commits behind head on release/chip-searchfield-pagination.

Additional details and impacted files
@@                           Coverage Diff                           @@
##           release/chip-searchfield-pagination    #2836      +/-   ##
=======================================================================
+ Coverage                                92.83%   92.88%   +0.05%     
=======================================================================
  Files                                      235      237       +2     
  Lines                                     4240     4270      +30     
  Branches                                  1029     1036       +7     
=======================================================================
+ Hits                                      3936     3966      +30     
  Misses                                     300      300              
  Partials                                     4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Appreciate your patience on the review :)

@adamstankiewicz adamstankiewicz merged commit 310480a into openedx:release/chip-searchfield-pagination Dec 8, 2023
13 checks passed
viktorrusakov pushed a commit that referenced this pull request Dec 28, 2023
adamstankiewicz pushed a commit that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants