-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: added Husky configurations #2949
[BD-46] feat: added Husky configurations #2949
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
8854ba8
to
6770b2a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2949 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 236 236
Lines 4273 4273
Branches 1033 1033
=======================================
Hits 3974 3974
Misses 295 295
Partials 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PKulkoRaccoonGang I left initial comments and will take a look later as well.
I think you should change printWidth setting in prettier config to match max line length setting that we have in eslint config. Otherwise, prettier does a lot of unnecessary changes by splitting what it thinks long lines into multiple lines
810c708
to
c78d304
Compare
1b1f608
to
3608692
Compare
🎉 This PR is included in version 21.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Issue: #2864
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist