-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: tablefooter design differences #2969
[BD-46] fix: tablefooter design differences #2969
Conversation
Thanks for the pull request, @khudym! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2969 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 236 236
Lines 4273 4273
Branches 1033 1033
=======================================
Hits 3974 3974
Misses 295 295
Partials 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khudym, Let's fix the upper-bound problem. In the issue, I provided a screenshot with a strange top border. Let's change it according to the component design.
I'm guessing that changing the $data-table-border
variable to 2px solid $light-300
should give users the correct display of the component.
Please add a link to the deployment preview of the component in the description 💯
🎉 This PR is included in version 21.12.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Fixed difference with design
Issue2904
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist