Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package-lock.json): Update our package-lock.json #87

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

jaebradley
Copy link
Contributor

@jaebradley jaebradley commented Nov 21, 2017

FEDX-412

Was accidentally committed previously, but with our migration to Node 8 (and post-React 16 migration from #45 ) we should keep this file up-to-date.

To generate this file I ran rm -rf ./node_modules/ ; npm cache clean; npm i.

TODO:

  • Resolve conflicts
  • Rebase

@jaebradley jaebradley self-assigned this Nov 21, 2017
@jaebradley jaebradley added enhancement Relates to new features or improvements to existing features ready for review work in progress and removed ready for review labels Nov 21, 2017
Was accidentally committed previously, but with our migration to Node 8
(https://openedx.atlassian.net/browse/FEDX-412) we should keep this file up-to-date

fix(package-lock): update values
@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Coverage remained the same at 99.505% when pulling c70a172 on node-8-lockfile into d059fbc on master.

Copy link
Contributor

@arizzitano arizzitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jaebradley jaebradley merged commit 25fe397 into master Nov 28, 2017
@jaebradley jaebradley deleted the node-8-lockfile branch November 28, 2017 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Relates to new features or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants