Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github url strings (org edx -> openedx) #291

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

sarina
Copy link
Contributor

@sarina sarina commented Sep 7, 2022

This PR was autogenerated

This pr replaces the old GitHub organization, github.com/edx, with the new GitHub organization, github.com/openedx.

Tagging @openedx/tcril-engineering for review, but others are welcome to provide review.

Ref: openedx/axim-engineering#42

@sarina sarina force-pushed the tcril/fix-gh-org-url branch 2 times, most recently from ffa809e to 8b7a020 Compare September 12, 2022 20:16
@sarina
Copy link
Contributor Author

sarina commented Sep 12, 2022

@Agrendalath - do you know why the CI is just hanging at the unit tests part?

It just took a long time, it's failing with this error:

Traceback (most recent call last):
  File "/home/runner/work/xblock-drag-and-drop-v2/xblock-drag-and-drop-v2/tests/integration/test_sizing.py", line 196, in test_wide_image_mobile
    self._check_mobile_container_size()
  File "/home/runner/work/xblock-drag-and-drop-v2/xblock-drag-and-drop-v2/tests/integration/test_sizing.py", line 191, in _check_mobile_container_size
    self.assertEqual(drag_container.size['width'], MOBILE_WINDOW_WIDTH - 2*horizontal_padding)
AssertionError: 984 != 360

This can't be due to my code. Any ideas how to proceed?

Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarina, I've noticed some non-deterministic test failures in this repo since we moved to GitHub Actions - e.g. #289 passed all checks but failed when I merged it. I've already scheduled an internal ticket for myself to check why it's happening. I'm planning to take a look at this early next week.

To avoid blocking this, I suggest merging it as-is, since these test failures are unrelated. Does it make sense?

@sarina
Copy link
Contributor Author

sarina commented Sep 13, 2022

@Agrendalath yep, totally makes sense, and thanks for the approval 😄

@sarina sarina merged commit 54c1446 into master Sep 13, 2022
@sarina sarina deleted the tcril/fix-gh-org-url branch September 13, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants