Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cereal: add cereal a header-only c++11 serialization library #313

Closed
wants to merge 5 commits into from
Closed

cereal: add cereal a header-only c++11 serialization library #313

wants to merge 5 commits into from

Conversation

amiartus
Copy link
Contributor

@amiartus amiartus commented Feb 1, 2021

cereal is a c++11 serialization library licensed under the BSD license.

I'm not owner or maintainer of said library and not sure whether approval of those is necessary for adding them to meta-oe, however I do use cereal in my embedded projects and thought it might be useful for others as well, hence providing my bitbake recipe.

@@ -24,3 +26,11 @@ EXTRA_OECMAKE += "\
"

S = "${WORKDIR}/git"

PROVIDES += "${PN}-dev"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cereal provides only header files for development, no binary or library is created during build. hence reflect that by providing dev package

@kraj
Copy link
Contributor

kraj commented Feb 3, 2021

this is now applied via e1b438c

@kraj kraj closed this Feb 3, 2021
@kraj
Copy link
Contributor

kraj commented Feb 4, 2021

We already have meta-oe/recipes-support/libcereal/libcereal_1.3.0.bb

I recommend ./meta-oe/recipes-devtools/cereal/cereal_1.0.bb is removed
again, and any relevant changes added to libcereal instead.

@kraj kraj reopened this Feb 4, 2021
@amiartus
Copy link
Contributor Author

amiartus commented Feb 9, 2021

@kraj you are correct, somehow I missed that. I plan to make and push the changes this week.

@kraj
Copy link
Contributor

kraj commented Feb 25, 2021

@kraj you are correct, somehow I missed that. I plan to make and push the changes this week.

I am still expecting you to consolidate this, otherwise, let me know, I will have to revert this pull.

@amiartus
Copy link
Contributor Author

@kraj updated to use already existing libcereal recipe

@kraj
Copy link
Contributor

kraj commented Feb 26, 2021

@kraj updated to use already existing libcereal recipe

I thought one of the recipes could be deleted as well isnt it so ?

@amiartus
Copy link
Contributor Author

amiartus commented Feb 27, 2021

reverted the original commit + later modification to cereal

there was a commit by @sashko that added ${datadir}/cmake to FILES_${PN}. I checked cereal and I havent seen it creating files in that directory, so not sure why that was necessary.

fixes CVE-2020-11105
adds license information for components of cereal
other minor fixes

Signed-off-by: Adam Miartus <adam.miartus@softhows.eu>
Signed-off-by: Adam Miartus <adam.miartus@softhows.eu>
Signed-off-by: Adam Miartus <adam.miartus@softhows.eu>
This reverts commit 12fe45e.

this component is already configured by 'libcereal'
This reverts commit e1b438c.

this component is already configured by 'libcereal'
@kraj
Copy link
Contributor

kraj commented Mar 4, 2021

this has been merged in master

@kraj kraj closed this Mar 4, 2021
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Feb 18, 2023
0001-Fix-build-with-libmicrohttpd.patch
removed since it's included in 1.4.1

Changelog:
===========
- Fedora CI build by updating to Catch v2.13.7
- Typo in README (openembedded#313)
- Deprecation warnings for Jsoncpp (openembedded#312)
- Compatibility with newer libmicrohttpd versions (>= 0.9.71) (openembedded#298 openembedded#299)
- Typo in diagram (openembedded#293)
- File descriptor leaks in connectors

- Vendoring catch library instead of downloading from github
- Moved from travis-ci to circleci (openembedded#311)
- Use '.empty()' checks instead of '.size() == 0'

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Feb 18, 2023
0001-Fix-build-with-libmicrohttpd.patch
removed since it's included in 1.4.1

Changelog:
===========
- Fedora CI build by updating to Catch v2.13.7
- Typo in README (openembedded#313)
- Deprecation warnings for Jsoncpp (openembedded#312)
- Compatibility with newer libmicrohttpd versions (>= 0.9.71) (openembedded#298 openembedded#299)
- Typo in diagram (openembedded#293)
- File descriptor leaks in connectors

- Vendoring catch library instead of downloading from github
- Moved from travis-ci to circleci (openembedded#311)
- Use '.empty()' checks instead of '.size() == 0'

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Feb 18, 2023
0001-Fix-build-with-libmicrohttpd.patch
removed since it's included in 1.4.1

Changelog:
===========
- Fedora CI build by updating to Catch v2.13.7
- Typo in README (openembedded#313)
- Deprecation warnings for Jsoncpp (openembedded#312)
- Compatibility with newer libmicrohttpd versions (>= 0.9.71) (openembedded#298 openembedded#299)
- Typo in diagram (openembedded#293)
- File descriptor leaks in connectors

- Vendoring catch library instead of downloading from github
- Moved from travis-ci to circleci (openembedded#311)
- Use '.empty()' checks instead of '.size() == 0'

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Sep 20, 2023
Remove the package override that is no longer needed
Update the inherits to use poetry

Changelog
=========
What's Changed
serialize: remove v1 and v2 formats by @woodruffw in openembedded#310
refactor: move the serialization implementation to method by @frostming in openembedded#313
feat: drop support of Python older than 3.7 by @frostming in openembedded#312
fix(typing): fix wrong types by @frostming in openembedded#314
workflows: add a release workflow by @woodruffw in openembedded#308
cachecontrol: 0.13.1 by @woodruffw in openembedded#315

Signed-off-by: Derek Straka <derek@asterius.io>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Sep 20, 2023
Remove the package override that is no longer needed
Update the inherits to use poetry

Changelog
=========
What's Changed
serialize: remove v1 and v2 formats by @woodruffw in openembedded#310
refactor: move the serialization implementation to method by @frostming in openembedded#313
feat: drop support of Python older than 3.7 by @frostming in openembedded#312
fix(typing): fix wrong types by @frostming in openembedded#314
workflows: add a release workflow by @woodruffw in openembedded#308
cachecontrol: 0.13.1 by @woodruffw in openembedded#315

Signed-off-by: Derek Straka <derek@asterius.io>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Sep 21, 2023
Remove the package override that is no longer needed
Update the inherits to use poetry

Changelog
=========
What's Changed
serialize: remove v1 and v2 formats by @woodruffw in openembedded#310
refactor: move the serialization implementation to method by @frostming in openembedded#313
feat: drop support of Python older than 3.7 by @frostming in openembedded#312
fix(typing): fix wrong types by @frostming in openembedded#314
workflows: add a release workflow by @woodruffw in openembedded#308
cachecontrol: 0.13.1 by @woodruffw in openembedded#315

Signed-off-by: Derek Straka <derek@asterius.io>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants