Skip to content

Commit

Permalink
Fix packaging for MacOS release builds
Browse files Browse the repository at this point in the history
Let CPack use sudo when invoking hdiutil to ensure that it succeeds.
This mitigates an issue that causes hdiutil to fail very often for MacOS
versions beyond 12. The cause of the issue is unknown.

See actions/runner-images#7522 (comment)
  • Loading branch information
leonlynch committed Oct 19, 2024
1 parent a41a663 commit 5e80d4e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/windows-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ jobs:
-DBUILD_EMV_TOOL=${{ matrix.build_emv_tool }} \
-DBUILD_EMV_VIEWER=${{ matrix.build_emv_viewer }} \
-DBUILD_MACOSX_BUNDLE=YES \
-DCPACK_COMMAND_HDIUTIL="/usr/bin/sudo /usr/bin/hdiutil" \
-DSIGN_MACOSX_BUNDLE=openemv.org
- name: Build
Expand Down

0 comments on commit 5e80d4e

Please sign in to comment.