fix(grumbles): remove error + updated docs

rpc/src/v1/helpers/errors.rs

@@ -57,7 +57,6 @@ mod codes {
 	pub const FETCH_ERROR: i64 = -32060;
 	pub const NO_LIGHT_PEERS: i64 = -32065;
 	pub const NO_PEERS: i64 = -32066;
-	pub const NO_LIGHT_TRANSACTIONS: i64 = -32066;
 	pub const DEPRECATED: i64 = -32070;
 	pub const EXPERIMENTAL_RPC: i64 = -32071;
 	pub const CANNOT_RESTART: i64 = -32080;
@@ -505,14 +504,6 @@ pub fn no_light_peers() -> Error {
 	}
 }
 
-pub fn no_light_transactions() -> Error {
-	Error {
-		code: ErrorCode::ServerError(codes::NO_LIGHT_TRANSACTIONS),
-		message: "No pending transactions in the light transaction queue".into(),
-		data: None,
-	}
-}
-
 pub fn deprecated<S: Into<String>, T: Into<Option<S>>>(message: T) -> Error {
 	Error {
 		code: ErrorCode::ServerError(codes::DEPRECATED),

rpc/src/v1/helpers/light_fetch.rs

@@ -522,10 +522,11 @@ where
 		}))
 	}
 
+	/// Helper to cull the `light` transaction queue of mined transactions
 	pub fn light_cull(&self, txq: Arc<RwLock<TransactionQueue>>) -> impl Future <Item = (), Error = Error> + Send {
 		let senders = txq.read().queued_senders();
 		if senders.is_empty() {
-			return Either::B(future::err(errors::no_light_transactions()));
+			return Either::B(future::err(errors::internal("No pending local transactions", "")));
 		}
 
 		let sync = self.sync.clone();

rpc/src/v1/impls/light/eth.rs

@@ -422,10 +422,10 @@ where
 	fn transaction_by_hash(&self, hash: H256) -> BoxFuture<Option<Transaction>> {
 		let in_txqueue = self.transaction_queue.read().get(&hash).is_some();
 
-		// The transaction is in the `local txqueue`
-		// Check if the nonce on the accounts are still fresh and return result from
-		// the `local txqueue` if it is still fresh.
-		// Otherwise make a network request to fetch the transaction from the network
+		// The transaction is in the `local txqueue` then fetch the latest state from the network and attempt
+		// to cull the transaction queue.
+		//
+		// If it fails return the local transaction
 		if in_txqueue {
 			// Note, this will block (relies on HTTP timeout) to make sure `cull` will finish to avoid having to call
 			// `eth_getTransactionByHash` more than once to ensure the `txqueue` is up to `date` when it is called