Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Recovery phrase not being fully displayed during account creation. #6581

Closed
DaleChristopher opened this issue Sep 24, 2017 · 7 comments
Closed
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Milestone

Comments

@DaleChristopher
Copy link

DaleChristopher commented Sep 24, 2017

I'm running:

  • Parity version: 1.7.0
  • Operating system: Windows 10
  • And installed: via installer
  • Tested using Edge Browser and Brave Browser

There is an issue during account creation regarding the recovery phrase issuance process. If parity is displayed in a windowed browser or on a screen in portrait orientation where the window width is insufficient, the recovery phrase will be cut off (partially not displayed )due to the QR code image covering it.

The recovery phrase process provides a "copy to clipboard" button to obtain the phrase however if the user is "writing down" the phrase from what is displayed on the screen, it is possible for the user to write down an incomplete recovery phrase possibly missing several (un-displayed) words. While being able to paste the phrase from the clipboard into the confirmation field using "CTRL+V". This can result in user being in possession of an incomplete recovery phrase if they rely on what is visually displayed for their own records.

Issues:

-1. Recovery phrase not being fully displayed under all circumstances.

-2. Confirmation of recovery phrase inadequate given the above issue.

Solutions:

-1. Change how the recovery phrase is displayed so that the phrase is not partially covered by the QR code image regardless of a user's browser window width or zoom settings.

-2. Change the recovery phrase confirmation process so that it better verifies the user has correctly obtained the recovery phrase. For example, Removing the "copy to clipboard" function and/or disable the ability to use "CTRL+V" to transfer the clipboard into the confirmation field. and/or issue the recovery phrase as an image rather than clipboard text.

Further prompting the user to check they have written down 12 words may also be beneficial.

Visual example of issue: http://gph.is/2xqwOeq
Note how recovery phrase words are covered by the QR code area however the advisory text directly below the recovery phrase scales to fit in response to the width available.

On a personal note: I have unfortunately fallen foul of this issue myself and am in possession of a recovery phrase where 1 and a half words appear to be missing, as such I can not recover/access my account. I was unaware at the time that it was possible for words to be covered by the QR code so didn't think to count to ensure I had written 12 down and just wrote what was displayed on the screen. Anyone with any advice on who I might contact to help with this issue please let me know in the comments. I imagine it may be possible for some basic script to be created to brute force the missing word/s but from my rough estimates the possible combinations are between 100k and 60million.

I believe it is important to address this issue swiftly, as it's possible many Parity users may currently be in possession of incomplete recovery phrases due to the issues outlined above. Any correction of these issues would also need to be accompanied by an attempt to alert all users to double check that they have a full recovery phrase in their possession.

@5chdn
Copy link
Contributor

5chdn commented Sep 25, 2017

It's impossible to create an account without knowing the full phrase.

Further prompting the user to check they have written down 12 words may also be beneficial.

That's exactly what Parity does before creating the account. Can you verify you are really on version 1.7.0?

@5chdn 5chdn added the Z1-question 🙋‍♀️ Issue is a question. Closer should answer. label Sep 25, 2017
@DaleChristopher
Copy link
Author

DaleChristopher commented Sep 25, 2017

Yer I'm on 1.7.0, the account was created in a prior version however the issue still exists. I must have used the "copy to clipboard" button to transfer the phrase to the second confirmation field however I backed up the phrase using a pen-paper relying on what is being visually displayed as well as taking a screenie and saving it on a USB for safe keeping.
Saving it as a text file copied using the copy to clipboard button would no doubt have been the way to go but as it is, I only have a pen&paper copy of the phrase and a backup screenshot in case I made any mistakes while writing it down. There's not really any indication that what is visually displayed may not be the entirety of the phrase. Indeed other text on the recovery phrase issuance page adjusts to fit the width, whereas the recover phrase itself can be hidden under the QR code area.

Using the copy button to obtain the phrase for the second confirmation field and using "CTRL+V" to transfer it there while using a pen+paper to create the actual phrase backup from what is (partially) visually displayed is one of the potential pitfalls here.

(I forgot about that confirmation step so I will adjust the issue report to better underline the problem.)

@tomusdrw
Copy link
Collaborator

On the confirmation step it's not possible to paste the recovery phrase (you need to actually type it) on non-test networks.
Are you suggesting that you could actually paste the phrase? What browser are you running?

@5chdn
Copy link
Contributor

5chdn commented Sep 26, 2017

I'm able to CTRL+V it on any network with Chromium/Linux.

@DaleChristopher
Copy link
Author

@tomusdrw,
Hi ^_^, it is indeed possible for me to paste the copied clipboard text into the confirmation field using CTRL+V. I believe this is correct on the current version of the Microsoft Edge browser and also Brave browser. On the mainnet.

@5chdn 5chdn added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M7-ui P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. and removed Z1-question 🙋‍♀️ Issue is a question. Closer should answer. labels Sep 27, 2017
@AyushyaChitransh
Copy link

Pardon me if I am late to address the issue, as I see that fix has already arrived. But I really like to have that ability to paste the code. And I think most developers need to create new parity test wallets every now and then, and would prefer to be able to paste the code.

To address the issue of users having missed part of recovery code by viewing, we can provide a download option, which would put the code in a file and make it available to be downloaded. Would that be sufficient?

@5chdn
Copy link
Contributor

5chdn commented Sep 29, 2017

Pardon me if I am late to address the issue, as I see that fix has already arrived. But I really like to have that ability to paste the code. And I think most developers need to create new parity test wallets every now and then, and would prefer to be able to paste the code.

If you are a developer, just set allYourBaseAreBelongToUs true in local storage. :octocat: b565108#diff-c3b306c9e26b82caff87d668e0502423R227

If you are not a developer, you certainly want to write down the full phrase or print it out.

To address the issue of users having missed part of recovery code by viewing, we can provide a download option, which would put the code in a file and make it available to be downloaded. Would that be sufficient?

You still can copy it. And "download" it, but I would strongly advise against doing this. The recovery phrase is not protected by a password and therefore should only be kept offline.

gavofyork pushed a commit that referenced this issue Oct 3, 2017
* Fix disallowing paste of recovery phrase on first run, ref #6581

* Allow the leader of CATS pasting recovery phrases.
arkpar pushed a commit that referenced this issue Oct 9, 2017
* Fix disallowing paste of recovery phrase on first run, ref #6581

* Allow the leader of CATS pasting recovery phrases.
arkpar added a commit that referenced this issue Oct 9, 2017
* Fix wallet view (#6597)

* Add safe fail for empty logs

* Filter transactions

* Add more logging

* Fix Wallet Creation and wallet tx list

* Remove logs

* Prevent selecting twice same wallet owner

* Fix tests

* Remove unused props

* Remove unused props

* Disallow pasting recovery phrases on first run (#6602)

* Fix disallowing paste of recovery phrase on first run, ref #6581

* Allow the leader of CATS pasting recovery phrases.

* Updated systemd files for linux (#6592)

Previous version put $BASE directory in root directory.
This version clearly explains how to run as root or as specific user.

Additional configuration:

* send SIGHUP for clean exit,

* restart on fail.

Tested on Ubuntu 16.04.3 LTS with 4.10.0-33-generic x86_64 kernel

* Don't expose port 80 for parity anymore (#6633)
@5chdn 5chdn added this to the 1.9 milestone Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Development

No branches or pull requests

4 participants