Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

JSON-RPC: Wrong specification or implementation? #8028

Closed
gagarin55 opened this issue Mar 1, 2018 · 2 comments
Closed

JSON-RPC: Wrong specification or implementation? #8028

gagarin55 opened this issue Mar 1, 2018 · 2 comments
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.

Comments

@gagarin55
Copy link

gagarin55 commented Mar 1, 2018

According to documentation of eth_getBlockByNumber when pending block requested result should have null in number field.

number: QUANTITY - the block number. null when its pending block.

But in the code of Parity I've found that it always returns number of next block :

impl<'x> OpenBlock<'x> {
	/// Create a new `OpenBlock` ready for transaction pushing.
	...
        let number = parent.number() + 1;
        ...

Could you please clarify can number has null value or not ?

Another question is about miner field. Could it has null value or not ?

@5chdn 5chdn added P5-sometimesoon 🌲 Issue is worth doing soon. F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. labels Mar 29, 2018
@5chdn 5chdn added this to the 1.11 milestone Mar 29, 2018
@5chdn
Copy link
Contributor

5chdn commented Mar 29, 2018

Pull requests welcome :)

@sorpaas
Copy link
Collaborator

sorpaas commented Mar 31, 2018

@gagarin55 Looks like miner field cannot be null. If I understand it correctly, if it is not set, the default will be 0x00...00.

KronicDeth added a commit to blockscout/blockscout that referenced this issue Jul 31, 2018
Fixes #490

Compatibility with openethereum/parity-ethereum#8281, which fixed
openethereum/parity-ethereum#8028 and made pending return be compliant
with Ethereum docs.
feliperenan pushed a commit to blockscout/blockscout that referenced this issue Aug 1, 2018
Fixes #490

Compatibility with openethereum/parity-ethereum#8281, which fixed
openethereum/parity-ethereum#8028 and made pending return be compliant
with Ethereum docs.
KronicDeth added a commit to blockscout/blockscout that referenced this issue Aug 1, 2018
Fixes #490

Compatibility with openethereum/parity-ethereum#8281, which fixed
openethereum/parity-ethereum#8028 and made pending return be compliant
with Ethereum docs.
alexgaribay pushed a commit to blockscout/blockscout that referenced this issue Aug 2, 2018
Fixes #490

Compatibility with openethereum/parity-ethereum#8281, which fixed
openethereum/parity-ethereum#8028 and made pending return be compliant
with Ethereum docs.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

No branches or pull requests

3 participants