Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

snap: fix path in script #10157

Merged
merged 6 commits into from
Jan 10, 2019
Merged

snap: fix path in script #10157

merged 6 commits into from
Jan 10, 2019

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Jan 9, 2019

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M1-ci 🙉 Continuous integration. labels Jan 9, 2019
@5chdn 5chdn added this to the 2.3 milestone Jan 9, 2019
@5chdn 5chdn added B1-patch-beta 🕷🕷 B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Jan 9, 2019
Copy link
Contributor

@gabreal gabreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested the path though

@@ -3,13 +3,13 @@
set -e # fail on any error
set -u # treat unset variables as error

TRACK=`awk -F '=' '/^track/ {print $2}' ./util/version/Cargo.toml`
TRACK=`awk -F '=' '/^track/ {print $2}' ../../util/version/Cargo.toml`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fixed the choice of the track
  • the path should start from the pkg source since .gitlab-ci.yml launches this file there.

@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 10, 2019
@5chdn 5chdn merged commit 4d66e8d into master Jan 10, 2019
@5chdn 5chdn deleted the a5-snap-patch branch January 10, 2019 09:58
This was referenced Jan 10, 2019
5chdn added a commit that referenced this pull request Jan 12, 2019
* snap: fix path in script

* debug, revert me

* fix

* necromancer awk magic

* awk necromancy and path fixing

* working track selection
5chdn added a commit that referenced this pull request Jan 15, 2019
* version: bump stable to 2.2.7

* version: mark 2.2 track stable

* version: mark update critical on all networks

* version: commit cargo lock

* Ping nodes from discovery (#10167)

* snap: fix path in script (#10157)

* snap: fix path in script

* debug, revert me

* fix

* necromancer awk magic

* awk necromancy and path fixing

* working track selection

* Fix _cannot recursively call into `Core`_ issue (#10144)

* Change igd to github:maufl/rust-igd

* Run `igd::search_gateway_from_timeout` from own thread

* Handle the case for contract creation on an empty but exist account with storage items (#10065)

* Add is_base_storage_root_unchanged

* Fix compile, use a shortcut for check, and remove ignored tests

* Add a warn!

* Update ethereum/tests to v6.0.0-beta.2

* grumble: use {:#x} instead of 0x{:x}

Co-Authored-By: sorpaas <accounts@that.world>

* version: bump fork blocks for kovan and foundation (#10186)

* pull constantinople on ethereum network (#10189)

* ethcore: pull constantinople on ethereum network

* version: mark update as critical

* ethcore: remove constantinople alltogether from chain spec

* version: revert fork block for ethereum
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M1-ci 🙉 Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants