Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Enable St-Peters-Fork ("Constantinople Fix") #10223

Merged
merged 6 commits into from
Jan 21, 2019
Merged

Enable St-Peters-Fork ("Constantinople Fix") #10223

merged 6 commits into from
Jan 21, 2019

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Jan 21, 2019 •
edited
Loading

  • disable eip-1283 on kovan block 10255201
  • disable eip-1283 on ropsten block 4939394
  • enable st-peters-fork on mainnet block 7280000
  • disable eip-1283 on sokol block 7026400

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. B1-patch-beta 🕷🕷 M2-config 📂 Chain specifications and node configurations. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Jan 21, 2019
@5chdn 5chdn added this to the 2.4 milestone Jan 21, 2019
@5chdn
Copy link
Contributor Author

5chdn commented Jan 21, 2019

paging @phahulin @varasev @vbaranov - which block number for Sokol and xDai?

tomusdrw
tomusdrw reviewed Jan 21, 2019
View reviewed changes
ethcore/res/ethereum/kovan.json Outdated
@@ -49,7 +49,8 @@
"eip1014Transition": "0x8c6180",
"eip1052Transition": "0x8c6180",
"eip1283Transition": "0x8c6180",
"kip4Transition": "0x8c6180",
"eip1283DisableTransition": "0x8c6180",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppsoe we want to keep kip4 at the same block and just schedule disabling of eip1283? The numbers should be swapped.

Copy link
Contributor Author

@5chdn 5chdn Jan 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good someone is actually looking at the specs 👍

This was referenced Jan 21, 2019
Merged
Merged
@varasev
Copy link
Contributor

varasev commented Jan 21, 2019

paging @phahulin @varasev @vbaranov - which block number for Sokol and xDai?

For Sokol, the block number is 7026400 (6 February).

For xDai we don't have spec json in ethcore/res/ethereum, so we'll define the block number for xDai and update our spec.json a bit later.

@varasev varasev mentioned this pull request Jan 21, 2019
Merged
@5chdn
Copy link
Contributor Author

5chdn commented Jan 21, 2019

ref ethereum/EIPs#1716

@5chdn 5chdn merged commit a9a278a into master Jan 21, 2019
@5chdn 5chdn deleted the a5-config-petersfork branch January 21, 2019 21:55
5chdn added a commit that referenced this pull request Jan 22, 2019
@5chdn
Enable St-Peters-Fork ("Constantinople Fix") (#10223)
2904b25 
* ethcore: disable eip-1283 on kovan block 10255201

* ethcore: disable eip-1283 on ropsten block 4939394

* ethcore: enable st-peters-fork on mainnet block 7280000

* ethcore: fix kovan chain spec

* version: update fork blocks

* ethcore: disable eip-1283 on sokol block 7026400
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 22, 2019
5chdn added a commit that referenced this pull request Jan 22, 2019
@5chdn
Enable St-Peters-Fork ("Constantinople Fix") (#10223)
7019a0f 
* ethcore: disable eip-1283 on kovan block 10255201

* ethcore: disable eip-1283 on ropsten block 4939394

* ethcore: enable st-peters-fork on mainnet block 7280000

* ethcore: fix kovan chain spec

* version: update fork blocks

* ethcore: disable eip-1283 on sokol block 7026400
5chdn added a commit that referenced this pull request Jan 22, 2019
@5chdn
Stable Backports 2.2.8 (#10224)
2a7dc64 
* version: bump stable to 2.2.8

* Update for Android cross-compilation. (#10180)

* build-unix update

* .gitlab-ci update

* Update build-unix.sh

add android postprocessing

* path to android lib

libparity.so

* fix path to libparity

* add android lib to artifacts

* Cancel Constantinople HF on POA Core (#10198)

* Add EIP-1283 disable transition (#10214)

* Enable St-Peters-Fork ("Constantinople Fix") (#10223)

* ethcore: disable eip-1283 on kovan block 10255201

* ethcore: disable eip-1283 on ropsten block 4939394

* ethcore: enable st-peters-fork on mainnet block 7280000

* ethcore: fix kovan chain spec

* version: update fork blocks

* ethcore: disable eip-1283 on sokol block 7026400
5chdn added a commit that referenced this pull request Jan 22, 2019
@5chdn
Beta Backports 2.3.1 (#10225)
3aefa2b 
* version: bump beta to 2.3.1

* Fix _cannot recursively call into `Core`_ issue (#10144)

* Change igd to github:maufl/rust-igd

* Run `igd::search_gateway_from_timeout` from own thread

* Update for Android cross-compilation. (#10180)

* build-unix update

* .gitlab-ci update

* Update build-unix.sh

add android postprocessing

* path to android lib

libparity.so

* fix path to libparity

* add android lib to artifacts

* Run all `igd` methods in its own thread (#10195)

* Cancel Constantinople HF on POA Core (#10198)

* Add EIP-1283 disable transition (#10214)

* Enable St-Peters-Fork ("Constantinople Fix") (#10223)

* ethcore: disable eip-1283 on kovan block 10255201

* ethcore: disable eip-1283 on ropsten block 4939394

* ethcore: enable st-peters-fork on mainnet block 7280000

* ethcore: fix kovan chain spec

* version: update fork blocks

* ethcore: disable eip-1283 on sokol block 7026400
ordian pushed a commit that referenced this pull request Mar 12, 2019
@5chdn @ordian
Enable St-Peters-Fork ("Constantinople Fix") (#10223)
cc45aa4 
* ethcore: disable eip-1283 on kovan block 10255201

* ethcore: disable eip-1283 on ropsten block 4939394

* ethcore: enable st-peters-fork on mainnet block 7280000

* ethcore: fix kovan chain spec

* version: update fork blocks

* ethcore: disable eip-1283 on sokol block 7026400
ordian pushed a commit that referenced this pull request Mar 13, 2019
@5chdn @ordian
Enable St-Peters-Fork ("Constantinople Fix") (#10223)
518d45b 
* ethcore: disable eip-1283 on kovan block 10255201

* ethcore: disable eip-1283 on ropsten block 4939394

* ethcore: enable st-peters-fork on mainnet block 7280000

* ethcore: fix kovan chain spec

* version: update fork blocks

* ethcore: disable eip-1283 on sokol block 7026400
@ordian ordian mentioned this pull request Mar 13, 2019
Closed
ordian pushed a commit that referenced this pull request Mar 15, 2019
@5chdn @ordian
Enable St-Peters-Fork ("Constantinople Fix") (#10223)
e907dfa 
* ethcore: disable eip-1283 on kovan block 10255201

* ethcore: disable eip-1283 on ropsten block 4939394

* ethcore: enable st-peters-fork on mainnet block 7280000

* ethcore: fix kovan chain spec

* version: update fork blocks

* ethcore: disable eip-1283 on sokol block 7026400
ordian pushed a commit that referenced this pull request Mar 15, 2019
@5chdn @ordian
Enable St-Peters-Fork ("Constantinople Fix") (#10223)
c941187 
* ethcore: disable eip-1283 on kovan block 10255201

* ethcore: disable eip-1283 on ropsten block 4939394

* ethcore: enable st-peters-fork on mainnet block 7280000

* ethcore: fix kovan chain spec

* version: update fork blocks

* ethcore: disable eip-1283 on sokol block 7026400
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw left review comments

@jam10o-new jam10o-new jam10o-new approved these changes

@lexfrl lexfrl lexfrl approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
5 participants
@5chdn @varasev @lexfrl @tomusdrw @jam10o-new