This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
SecretStore: non-blocking wait of session completion #10303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A0-pleasereview 🤓
svyatonik
changed the title
|
Hi! We were using the old commit for two weeks and we stop suffering the connection issues with secret store. Do you think this can be merged soon? |
jam10o-new
added
B0-patch-stable 🕷
|
@svyatonik I'm getting rid of onice because previous pr has been merged |
jam10o-new
removed
the
A1-onice 🌨
svyatonik
force-pushed
the
fix_ss_blocking_wait
branch
from
478d60e
to
d6a3c66
Compare
Closed
dvdplm
reviewed
Jun 4, 2019
secret-store/src/key_server_cluster/client_sessions/signing_session_schnorr.rs
Outdated
Show resolved
Hide resolved
dvdplm
approved these changes
Jun 4, 2019
dvdplm
added
A8-looksgood 🦄
svyatonik
added
the
A7-looksgoodcantmerge 🙄
svyatonik
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Jun 6, 2019
This was referenced Jun 11, 2019
dvdplm
added a commit
that referenced
this pull request
Jun 17, 2019
* master: updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731) Stop breaking out of loop if a non-canonical hash is found (#10729) Refactor Clique stepping (#10691) Use RUSTFLAGS to set the optimization level (#10719) SecretStore: non-blocking wait of session completion (#10303) removed secret_store folder (#10722) SecretStore: expose restore_key_public in HTTP API (#10241) Revert "enable lto for release builds (#10717)" (#10721) enable lto for release builds (#10717) Merge `Notifier` and `TransactionsPoolNotifier` (#10591)
dvdplm
added a commit
that referenced
this pull request
Jun 18, 2019
* master: Enable aesni (#10756) remove support of old SS db formats (#10757) [devp2p] Don't use `rust-crypto` (#10714) updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731) Stop breaking out of loop if a non-canonical hash is found (#10729) Refactor Clique stepping (#10691) Use RUSTFLAGS to set the optimization level (#10719) SecretStore: non-blocking wait of session completion (#10303) removed secret_store folder (#10722) SecretStore: expose restore_key_public in HTTP API (#10241) Revert "enable lto for release builds (#10717)" (#10721) enable lto for release builds (#10717) Merge `Notifier` and `TransactionsPoolNotifier` (#10591)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10266
on top of #9850 (commits before this one are from separate PR) - 'onicing' it until previous PR is merged
This PR makes SS sessions return
Futures, so thatRuntimethreads aren't blocked withSession::wait()calls.cc @jcortejoso