This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Update to latest mem-db, hash-db and trie-db. #10314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
approved these changes
Feb 19, 2019
ethcore/light/src/cht.rs
Outdated
| @@ -73,7 +74,8 @@ impl<DB: HashDB<KeccakHasher, DBValue>> CHT<DB> { | |||
| if block_to_cht_number(num) != Some(self.number) { return Ok(None) } | |||
|
|
|||
| let mut recorder = Recorder::with_depth(from_level); | |||
| let t = TrieDB::new(&self.db, &self.root)?; | |||
| let db: &HashDB<_,_> = &self.db; | |||
5chdn
added
A8-looksgood 🦄
ordian
reviewed
Feb 20, 2019
indentation Co-Authored-By: cheme <emericchevalier.pro@gmail.com>
Co-Authored-By: cheme <emericchevalier.pro@gmail.com>
ordian
added a commit
that referenced
this pull request
Apr 5, 2019
* master: fix #10390 (#10391) Fix to_pod storage trie value decoding (#10368) revert some changes, could be buggy (#10399) version: bump nightly to 2.5 (#10392) no-git for publish jobs, empty artifacts dir (#10393) fix(jni): bump to jni to 0.11 & remove unsafe impl (#10394) chore(bump ethereum-types) (#10396) Update to latest mem-db, hash-db and trie-db. (#10314) tx pool: always accept local transactions (#10375)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates parity-ethereum to use parity-trie crate, this is part of paritytech/trie#5 and follows paritytech/parity-common#106 .
A few point of attention in this PR: