This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
simplify ethcore machine by removing redundant traits #10454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
seunlanlege
approved these changes
Mar 7, 2019
soc1c
added
A8-looksgood 🦄
ascjones
approved these changes
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
machine engine is too complex and we don't need it to be so generic. In the following pull requests I will try to simplify it to the bare minimum
changes:
ScoredHeaderFinalizableHeaderWithMetadataHeaderTotalScoredHeaderand moved it's implementation toExtendedHeadertype ExtendedHeaderfromtrait Machine. There is only one implementation of this type, so there is no reason to have it generic