Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fix Sha3/keccak256 hash calculation for binaries #10509

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Conversation

General-Beck
Copy link
Contributor

Fix for #10495
Calculate a hash only for x86_64 architectures
x86_64-unknown-linux-gnu & x86_64-apple-darwin

@General-Beck General-Beck self-assigned this Mar 22, 2019
@General-Beck General-Beck added F2-bug 🐞 The client fails to follow expected behavior. A0-pleasereview 🤓 Pull request needs code review. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. M1-ci 🙉 Continuous integration. labels Mar 22, 2019
@soc1c soc1c added B1-patch-beta 🕷🕷 B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. and removed F2-bug 🐞 The client fails to follow expected behavior. labels Mar 22, 2019
@soc1c soc1c added this to the 2.5 milestone Mar 22, 2019
Copy link
Contributor

@soc1c soc1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@soc1c soc1c added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 22, 2019
Copy link
Collaborator

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So AFAIU this hash is needed for the autoupdate to work. It's not crtical for not x86-64 yet.
Ok then.

@TriplEight TriplEight merged commit f2c34f7 into master Mar 22, 2019
@soc1c soc1c deleted the ci-sha3-fix branch March 22, 2019 10:53
@soc1c soc1c mentioned this pull request Mar 27, 2019
11 tasks
@soc1c soc1c mentioned this pull request Mar 27, 2019
11 tasks
soc1c added a commit that referenced this pull request Apr 1, 2019
* version: bump stable

* fix Sha3/keccak256 hash calculation for binaries (#10509)

#10495

* verbose flag for cpp tests (#10524)

* Initial support sccache for windows build (#10520)

* Initial support sccache for win build

* show sccache stats

* cache paths for shared runners

* sccache status is in the script.

* removed windows test for now

* ethcore: remove eth social and easthub chain configs (#10531)

* Fix max_gas (#10537)

Fix max_gas

* build android with cache, win fixes (#10546)

* build android with cache!

* windows fixes

* windows fixes 2

* windows fixes 3

* windows fixes 4

* windows should have sccache variables in env variables

* Update light client harcoded headers (#10547)

* kovan #10643457

* ropsten #5296129

* foundation #7460865

* classic #7747585

* indentation

* morden #3973121
soc1c added a commit that referenced this pull request Apr 1, 2019
* version: bump beta

* fix Sha3/keccak256 hash calculation for binaries (#10509)

#10495

* verbose flag for cpp tests (#10524)

* Initial support sccache for windows build (#10520)

* Initial support sccache for win build

* show sccache stats

* cache paths for shared runners

* sccache status is in the script.

* removed windows test for now

* ethcore: remove eth social and easthub chain configs (#10531)

* Fix max_gas (#10537)

Fix max_gas

* build android with cache, win fixes (#10546)

* build android with cache!

* windows fixes

* windows fixes 2

* windows fixes 3

* windows fixes 4

* windows should have sccache variables in env variables

* Update light client harcoded headers (#10547)

* kovan #10643457

* ropsten #5296129

* foundation #7460865

* classic #7747585

* indentation

* morden #3973121
ordian added a commit that referenced this pull request Apr 5, 2019
* master: (48 commits)
  ethcore: remove eth social and easthub chain configs (#10531)
  Initial support sccache for windows build (#10520)
  fix(light): make `OnDemand` generic instead of using the concrete type (#10514)
  private-tx: replace error_chain (#10510)
  Add trace information to eth_estimateGas (#10519)
  ethcore: add clique engine (#9981)
  verbose flag for cpp tests (#10524)
  Add a more realistic Batch test (#10511)
  docs: add changelogs for 2.3.{6,7,8} and 2.4.{1,2,3} (#10494)
  fix(rpc): fix a bunch of clippy lints (#10493)
  fix Sha3/keccak256 hash calculation for binaries (#10509)
  Add additional request tests (#10503)
  whisper/cli: add p2p port and ip parameters (#10057)
  fix(time-utils): add missing license (#10497)
  fix(extract `timestamp_checked_add` as lib) (#10383)
  fix(rpc): lint `unused_extern_crates` + fix warns (#10489)
  fix win&mac build (#10486)
  Сaching through docker volume (#10477)
  OpenBlock::new take IntoIterator instead of mutable ref to Iterator (#10480)
  simplify block module and usage (#10479)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M1-ci 🙉 Continuous integration. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants