This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Stop breaking out of loop if a non-canonical hash is found #10566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently investigating #10085 with the help of @tomusdrw. We have a couple theories floating around, but we aren't sure how to reproduce them on our own.
We've narrowed down the cause to one of three function calls within
Blockchain::epoch_transition_for
. This PR handles theNone
case of what we think is the most suspect function call better, as well as adds some additional logging so we can track where we are the loop.