This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
s3krit
commented
Aug 14, 2019
•
edited
Loading
edited
- Add support for Energy Web Foundation's new chains (Add support for Energy Web Foundation's new chains #10957)
- Kaspersky AV whitelisting (Kaspersky AV whitelisting #10919)
- Avast whitelist script (Avast whitelist script #10900)
- Docker images renaming (Docker images renaming #10863)
- Remove excessive warning (Remove excessive warning #10831)
- Allow --nat extip:your.host.here.org (Allow --nat extip:your.host.here.org #10830)
- When updating the client or when called from RPC, sleep should mean sleep (When updating the client or when called from RPC, sleep should mean sleep #10814)
- added new ropsten-bootnode and removed old one (added new ropsten-bootnode and removed old one #10794)
- ethkey no longer uses byteorder (ethkey no longer uses byteorder #10786)
- Do not drop the peer with None difficulty (Do not drop the peer with None difficulty #10772)
- docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions #10652)
- [Cargo.lock] cargo update -p crossbeam-epoch (Fix cargo audit #10921)
* docker images renaming [skip ci]
* Add Avast AV whitelisting publish script * Update gitlab-ci.yml, publish-av-whitelists.sh * remove debug print
* tx-pool: accept local tx with higher gas price when pool full * Revert "tx-pool: accept local tx with higher gas price when pool full" This reverts commit 9d4adc5 * tx-pool: new tx with same nonce as existing is ready * tx-pool: explicit check for replacement tx (same sender & nonce) * Update comment Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com> * Replace `ReplaceOld` with `InsertNew` for replacement txs
* Add Kaspersky's FTP to AV Whitelisting release script * Uncommented lines commented for debugging
* Change the return type of step_inner function. * Fix indention.
* add(chain-support): new ewf chains support added - volta test network - ewc production chain * remove(tobalaba): ewf chain tobalaba support removal - tobalaba is deprecated so not officially supported by ewf any more
ordian
added
the
A8-backport 🕸
Pull request is already reviewed well in another branch.
label
Aug 14, 2019
jam10o-new
approved these changes
Aug 14, 2019
ordian
approved these changes
Aug 14, 2019
// | ||
// With replacement transactions we can safely return `InsertNew` here, because | ||
// we don't need to remove `old` (worst transaction in the pool) since `new` will replace | ||
// some other transaction in the pool so we will never go above limit anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no, some spaces snuck into the master!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.