This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Extract snapshot to own crate #11010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort out imports
Sort out tests
dvdplm
added
A3-inprogress ⏳
dvdplm
added
A0-pleasereview 🤓
niklasad1
reviewed
Sep 2, 2019
niklasad1
reviewed
Sep 2, 2019
Co-Authored-By: Niklas Adolfsson <niklasadolfsson1@gmail.com>
dvdplm
commented
Sep 2, 2019
niklasad1
approved these changes
Sep 2, 2019
ordian
reviewed
Sep 2, 2019
I wish I had something intelligent to say here, but tbh I followed the compilers' orders and she asked for |
ordian
approved these changes
Sep 3, 2019
ordian
added
A8-looksgood 🦄
dvdplm
added a commit
that referenced
this pull request
Sep 3, 2019
…he-right-place * master: Extract snapshot to own crate (#11010) Edit publish-onchain.sh to use https (#11016) EIP 1108: Reduce alt_bn128 precompile gas costs (#11008) Fix deadlock in `network-devp2p` (#11013) Implement EIP-1283 reenable transition, EIP-1706 and EIP-2200 (#10191) EIP 1884 Re-pricing of trie-size dependent operations (#10992)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract
snapshotto its own crate. Nothing particularly interesting to see here: shuffling files around and move types&traits to where they need to be. Adds a few more generics to thesnapshotcrate to disentangle it fromethcore::Client.One needed refactoring is not present here: putting back
SnapshotClientandSnapshotWriterinsnapshot. This is taken care of in #11012 as it turned out to be more involved than I thought.I have warp synced mainnet and I have observed snapshot chunks being created with this branch.
@niklasad1 Maybe this enables snapshots for the light client?