Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[evmbin] fix time formatting #11060

Merged
merged 1 commit into from
Sep 16, 2019
Merged

[evmbin] fix time formatting #11060

merged 1 commit into from
Sep 16, 2019

Conversation

ordian
Copy link
Collaborator

@ordian ordian commented Sep 16, 2019

The timing information was displayed incorrectly due to right padding.
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e6b3607859f46f1304a0159804c45d37

Thanks @holiman for spotting this.

@ordian ordian added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Sep 16, 2019
@ordian ordian added this to the 2.7 milestone Sep 16, 2019
@niklasad1 niklasad1 added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 16, 2019
@ordian ordian merged commit bceb1d5 into master Sep 16, 2019
@ordian ordian deleted the ao-fix-evmbin-time-reporting branch September 16, 2019 13:14
dvdplm added a commit that referenced this pull request Sep 18, 2019
* master:
  [ethcore]: move client test types to test-helpers (#11062)
  [sync]: remove unused dependencies or make dev (#11061)
  [ethcore]: reduce re-exports (#11059)
  [evmbin] fix time formatting (#11060)
  Update hardcoded headers (foundation, classic, kovan,  xdai, ewc, ...) (#11053)
  cargo update -p eth-secp256k1 (#11052)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants