Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Adds support for ipc socket permissions #11273

Merged
merged 13 commits into from
Dec 6, 2019
Merged

Adds support for ipc socket permissions #11273

merged 13 commits into from
Dec 6, 2019

Conversation

seunlanlege
Copy link
Member

@seunlanlege seunlanlege commented Nov 20, 2019 •
edited
Loading

Adds support for setting file permissions using chmod on IPC sockets through CLI or config files.

closes #9703

@seunlanlege seunlanlege added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M4-core ⛓ Core client code / Rust. labels Nov 20, 2019
@seunlanlege seunlanlege marked this pull request as ready for review November 29, 2019 10:27
@seunlanlege seunlanlege added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 29, 2019
@seunlanlege seunlanlege requested review from dvdplm and ordian and removed request for dvdplm November 29, 2019 10:28
dvdplm
dvdplm reviewed Nov 29, 2019
View reviewed changes
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but I have questions!

parity/rpc.rs Outdated Show resolved Hide resolved
rpc/src/lib.rs Outdated Show resolved Hide resolved
rpc/src/lib.rs Outdated Show resolved Hide resolved
niklasad1
niklasad1 reviewed Nov 29, 2019
View reviewed changes
parity/cli/mod.rs Outdated Show resolved Hide resolved
ordian
ordian approved these changes Nov 29, 2019
View reviewed changes
parity/cli/mod.rs Outdated Show resolved Hide resolved
@ordian ordian added this to the 2.7 milestone Nov 29, 2019
@ordian ordian added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 29, 2019
dvdplm
dvdplm reviewed Nov 29, 2019
View reviewed changes
parity/cli/mod.rs Outdated Show resolved Hide resolved
parity/rpc.rs Outdated Show resolved Hide resolved
parity/cli/mod.rs Outdated Show resolved Hide resolved
@dvdplm
Copy link
Collaborator

dvdplm commented Nov 29, 2019

@seunlanlege once this lands, make sure you edit the wiki to document the new option.

ordian
ordian reviewed Dec 2, 2019
View reviewed changes
rpc/src/lib.rs Outdated Show resolved Hide resolved
@seunlanlege seunlanlege force-pushed the seun-ipc-socket-permissions branch from c5b58ce to 7e98827 Compare December 2, 2019 14:11
niklasad1
niklasad1 reviewed Dec 2, 2019
View reviewed changes
parity/rpc.rs Outdated Show resolved Hide resolved
@seunlanlege
Copy link
Member Author

seunlanlege commented Dec 3, 2019 •
edited
Loading

Putting this on ice because parity-tokio-ipc doesn't support android builds, yet

@seunlanlege seunlanlege added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Dec 3, 2019
ordian
ordian approved these changes Dec 3, 2019
View reviewed changes
parity/rpc.rs Outdated Show resolved Hide resolved
parity/rpc.rs Outdated Show resolved Hide resolved
@dvdplm
Copy link
Collaborator

dvdplm commented Dec 4, 2019

Putting this on ice because parity-tokio-ipc doesn't support android builds, yet

error[E0308]: mismatched types
  --> /ci-cache/parity-ethereum/cargo/build-android/registry/src/gh.neting.cc-1ecc6299db9ec823/parity-tokio-ipc-0.3.0/src/unix_permissions.rs:50:37
   |
50 |             if chmod(path.as_ptr(), mode) == -1 {
   |                                     ^^^^ expected u16, found u32
help: you can convert an `u32` to `u16` and panic if the converted value wouldn't fit
   |
50 |             if chmod(path.as_ptr(), mode.try_into().unwrap()) == -1 {
   |                                     ^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0308`.
error: could not compile `parity-tokio-ipc`.

Is that what you mean? Seems more like a legit error than some incompatibility to me.

@niklasad1
Copy link
Collaborator

@dvdplm it is fixed in paritytech/parity-tokio-ipc#18

I think we can change label to in progress

niklasad1
niklasad1 reviewed Dec 4, 2019
View reviewed changes
rpc/Cargo.toml Outdated Show resolved Hide resolved
niklasad1
niklasad1 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Dec 4, 2019
@seunlanlege seunlanlege force-pushed the seun-ipc-socket-permissions branch from 2acdde0 to 377cc11 Compare December 4, 2019 16:03
@niklasad1
Copy link
Collaborator

niklasad1 commented Dec 4, 2019 •
edited
Loading

@seunlanlege please commit the updated Cargo.lock in order to fix the CI errors.

dvdplm
dvdplm approved these changes Dec 5, 2019
View reviewed changes
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo CI

@ordian ordian merged commit 64295fd into master Dec 6, 2019
@ordian ordian deleted the seun-ipc-socket-permissions branch December 6, 2019 15:40
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Dec 6, 2019
dvdplm added a commit that referenced this pull request Dec 9, 2019
@dvdplm
Merge branch 'master' into dp/chore/kvdb-no-default-column
bf1bfea 
* master:
  Istanbul activation on xDai (#11299)
  Istanbul activation on POA Core (#11298)
  Adds support for ipc socket permissions (#11273)
  Add check for deserialising hex values over U256 limit (#11309)
  validate-chainspecs: check istanbul eips are in the foundation spec (#11305)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@ordian ordian ordian approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust. M6-rpcapi 📣 RPC API.
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.

Enhancement: IPC file permission
4 participants
@seunlanlege @dvdplm @niklasad1 @ordian