This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
remove null signatures #11335
Merged
remove null signatures #11335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-pleasereview 🤓
ordian
commented
Dec 13, 2019
dvdplm
reviewed
Dec 13, 2019
| if !allow_empty_signature && self.is_unsigned() { | ||
| pub fn verify_basic(&self, check_low_s: bool, chain_id: Option<u64>) -> Result<(), error::Error> { | ||
| // Disallow unsigned transactions. | ||
| if self.is_unsigned() { | ||
| return Err(parity_crypto::publickey::Error::InvalidSignature.into()); |
There was a problem hiding this comment.
Should we have a Error::Unsigned you think?
tomusdrw
approved these changes
Dec 13, 2019
| @@ -31,7 +31,8 @@ use transaction::error; | |||
| type Bytes = Vec<u8>; | |||
| type BlockNumber = u64; | |||
|
|
|||
| /// Fake address for unsigned transactions as defined by EIP-86. | |||
| /// Fake address for unsigned transactions as defined by Legacy EIP-86. | |||
| #[cfg(any(test, feature = "test-helpers"))] | |||
| pub const UNSIGNED_SENDER: Address = H160([0xff; 20]); | |||
There was a problem hiding this comment.
Why not remove this entirely?
There was a problem hiding this comment.
What to do with
- https://github.com/paritytech/parity-ethereum/blob/6e76be7fad1cf1ae40773183084f13c37acabdde/ethcore/machine/src/machine.rs#L155-L156
- https://github.com/paritytech/parity-ethereum/blob/6e76be7fad1cf1ae40773183084f13c37acabdde/ethcore/machine/src/externalities.rs#L262
- (probably just remove) https://github.com/paritytech/parity-ethereum/blob/6e76be7fad1cf1ae40773183084f13c37acabdde/ethcore/types/src/transaction/transaction.rs#L503-L505
There was a problem hiding this comment.
- Try to remove
Option<>fromcontract_address- I suppose it will always be set toSome. - Remove along with
keep_unsigned_nonceparameter from schedule, it's always set tofalseanyway. - Just remove along with
fn is_unsignedmethods from all*Transactionstructs.
There was a problem hiding this comment.
Just checked and it seems 1. needs to stay, as it's being used by block-reward calls inside the engine, so let's leave it as is. So I guess we can keep the constant, but try to remove everything else.
dvdplm
approved these changes
Dec 13, 2019
This reverts commit be29f03.
|
I don't have time to investigate this failure https://gitlab.parity.io/parity/parity-ethereum/-/jobs/331339. My suggestion is to merge it as is, more cleanup can be done in a followup PR. |
Works for me. @tomusdrw? |
|
Yeah, sounds good! Let's just not forget that :) |
ordian
added a commit
that referenced
this pull request
Dec 13, 2019
* master: remove null signatures (#11335)
dvdplm
pushed a commit
that referenced
this pull request
Dec 13, 2019
* tx: clean up legacy eip-86 based null signature * tx: add a test for null signature rejection * tx: revert json txn changes * fix evmbin bench build * tx: put UNSIGNED_SENDER behind 'test-helpers' feature * Revert "tx: put UNSIGNED_SENDER behind 'test-helpers' feature" This reverts commit 1dde478. * tx: add comment for null_sign * even more cleanup * Revert "even more cleanup" This reverts commit be29f03.
dvdplm
pushed a commit
that referenced
this pull request
Dec 13, 2019
* tx: clean up legacy eip-86 based null signature * tx: add a test for null signature rejection * tx: revert json txn changes * fix evmbin bench build * tx: put UNSIGNED_SENDER behind 'test-helpers' feature * Revert "tx: put UNSIGNED_SENDER behind 'test-helpers' feature" This reverts commit 1dde478. * tx: add comment for null_sign * even more cleanup * Revert "even more cleanup" This reverts commit be29f03.
dvdplm
added a commit
that referenced
this pull request
Dec 15, 2019
…ate their data instead Merge branch 'master' into dp/chore/kvdb-no-default-column * master: tx-q: enable basic verification of local transactions (#11332) remove null signatures (#11335) ethcore/res: activate agharta on classic 9573000 (#11331) [secretstore] migrate to version 4 (#11322) Enable EIP-2384 for ice age hard fork (#11281) Fix atomicity violation in network-devp2p (#11277)
s3krit
pushed a commit
that referenced
this pull request
Dec 16, 2019
* Enable EIP-2384 for ice age hard fork (#11281) * ethcore/res: activate agharta on classic 9573000 (#11331) * Istanbul HF in xDai (2019-12-12) (#11299) * Istanbul HF in POA Core (2019-12-19) (#11298) * Istanbul HF in POA Sokol (2019-12-05) (#11282) * Activate ecip-1061 on kotti and mordor (#11338) * Enable basic verification of local transactions (#11332) * Disallow EIP-86 style null signatures for transactions outside tests (#11335)
s3krit
pushed a commit
that referenced
this pull request
Dec 16, 2019
* Enable EIP-2384 for ice age hard fork (#11281) * ethcore/res: activate agharta on classic 9573000 (#11331) * Istanbul HF in xDai (2019-12-12) (#11299) * Istanbul HF in POA Core (2019-12-19) (#11298) * Istanbul HF in POA Sokol (2019-12-05) (#11282) * Activate ecip-1061 on kotti and mordor (#11338) * Enable basic verification of local transactions (#11332) * Disallow EIP-86 style null signatures for transactions outside tests (#11335) * SecretStore database migration to v4 (#11322)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eip86Transitionflag was removed in #9140, this PR removes the null-signature as a follow-up cleanup.