This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Misc fixes #11510
Merged
Misc fixes #11510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did some code reading and made random changes as I went.
dvdplm
added
A0-pleasereview 🤓
ordian
approved these changes
Feb 22, 2020
| //// TODO: cloning for `State` shouldn't be possible in general; Remove this and use | ||
| //// checkpoints where possible. | ||
| // TODO: cloning for `State` shouldn't be possible in general; Remove this and use | ||
| // checkpoints where possible. |
There was a problem hiding this comment.
do we have an issue for this?
There was a problem hiding this comment.
Not that I know of no. I'm hesitant to add one because I don't fully understand why state should not be cloneable. Do you?
There was a problem hiding this comment.
it was added in #4632,
other related PRs
I assume that using checkpoints instead of Clones is more efficient, since we only store the diff.
We still use clones here https://github.com/paritytech/parity-ethereum/blob/856a0755888a30d4dc52a68cb2638a8bfd5786ac/ethcore/src/block.rs#L239
cc @tomusdrw
| /// Creates new cache config with cumulative size equal `total`. | ||
| /// Creates new cache config with cumulative size equal to `total`, distributed as follows: 70% | ||
| /// to rocksdb, 10% to the blockchain cache and 20% to the state cache. The transaction queue | ||
| /// cache size is set to 40Mb and the trace cache to 20Mb. |
There was a problem hiding this comment.
I wonder if we should reconsider the defaults
There was a problem hiding this comment.
You might be right. Or not. Really hard to even have an opinion about this without some serious testing.
Co-Authored-By: Andronik Ordian <write@reusable.software>
niklasad1
approved these changes
Feb 23, 2020
ordian
added a commit
that referenced
this pull request
Mar 6, 2020
* master: (27 commits) Faster kill_garbage (#11514) [EngineSigner]: don't sign message with only zeroes (#11524) fix compilation warnings (#11522) [ethcore cleanup]: various unrelated fixes from `#11493` (#11507) Add benchmark for transaction execution (#11509) Add Smart Contract License v1.0 Misc fixes (#11510) [dependencies]: unify `rustc-hex` (#11506) Activate on-chain randomness in POA Sokol (#11505) Grab bag of cleanup (#11504) Implement eth/64 (EIP-2364) and drop support for eth/62 (#11472) [dependencies]: remove `util/macros` (#11501) OpenEthereum bootnodes are added (#11499) [ci benches]: use `all-features` (#11496) [verification]: make test-build compile standalone (#11495) complete null-signatures removal (#11491) Include the seal when populating the header for a new block (#11475) fix compilation warnings (#11492) cargo update -p cmake (#11490) update to published rlp-derive (#11489) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some code reading and made random changes as I went.