This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
hackiest possible fix for $ETC forkid issue #11746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please help me fix this, it probably won't even compile. Signed-off-by: meows <b5c6@protonmail.com>
|
We should address the root cause instead of such hacky workarounds. |
|
Absolutely. But this is a critical issue that is segregating the network right now and I'm trying to get this done yesterday, and I don't think the proposed change would theoretically negatively impact any other concerns as a temporary solution. |
meowsbits
commented
Jun 1, 2020
| trace!(target: "sync", "Peer {} incompatible fork id (fork id: {:#x}/{}, error: {:?})", peer_id, fork_id.hash.0, fork_id.next, reason); | ||
| return Err(DownloaderImportError::Invalid); | ||
| // 0x9007bfcc/0 <-- Ethereum Classic post-Phoenix fork (core-geth, multi-geth) | ||
| if fork_id.hash.0 == 0x9007bfcc && fork_id.next == 0 { |
There was a problem hiding this comment.
This is almost certainly not the correct way to compare the desired hash. Must fix?
|
@meowsbits Rest assured I think we've just identified the root cause. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please help me fix this, it probably won't even compile.
I am not a Rustacean, I do not know how to write Rust code.
This is intended to be the simplest and fastest possible (and temporary) hotfix for the production ETC issue.
Rel https://github.com/openethereum/openethereum/issues/11744