Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix several RPCs #1926

Merged
merged 8 commits into from
Aug 17, 2016
Merged

Fix several RPCs #1926

merged 8 commits into from
Aug 17, 2016

Conversation

gavofyork
Copy link
Contributor

@gavofyork gavofyork commented Aug 13, 2016 •
edited
Loading

  • Fix pending receipts details;
  • Fix block size (now hex-encoded quantity rather than number);
  • Introduce ethcore_registryAddress.

@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Aug 13, 2016
@gavofyork
Copy link
Contributor Author

test failure looks spurious

@gavofyork gavofyork closed this Aug 14, 2016
@gavofyork gavofyork reopened this Aug 14, 2016
NikVolf
NikVolf reviewed Aug 15, 2016
View reviewed changes
ethcore/src/client/traits.rs
@@ -14,6 +14,9 @@
// You should have received a copy of the GNU General Public License
// along with Parity. If not, see <http://www.gnu.org/licenses/>.


Copy link
Contributor

@NikVolf NikVolf Aug 15, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant empty line?

@NikVolf
Copy link
Contributor

NikVolf commented Aug 15, 2016 •
edited
Loading

no tests that could have specified how this actually works / supposed to be used?

@NikVolf NikVolf added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 15, 2016
@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Aug 16, 2016
@gavofyork gavofyork changed the title Fix up pending receipts details. Fix several RPCs Aug 16, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 16, 2016
@arkpar arkpar added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Aug 16, 2016
@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Aug 16, 2016
@coveralls
Copy link

coveralls commented Aug 16, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling ae27eb1 on rpc-fix into * on master*.

@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Aug 17, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7089c97 on rpc-fix into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8140cb2 on rpc-fix into * on master*.

@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Aug 17, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Aug 17, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 86.98% when pulling 0ad5421 on rpc-fix into bcf6b0b on master.

@gavofyork gavofyork merged commit ccdf80f into master Aug 17, 2016
@gavofyork gavofyork deleted the rpc-fix branch August 17, 2016 17:25
arkpar pushed a commit that referenced this pull request Sep 11, 2016
@gavofyork @arkpar
Fix several RPCs (#1926)
954db13 
* Fix up pending receipts details.

* Add support for additional params and registry over RPC.

* Fix tests.

* Add test, additional fix.

Fixes #1932.

* Fix up tests.

* Fix test.

* Fix test.
arkpar added a commit that referenced this pull request Sep 11, 2016
@arkpar
Backports to beta (#2068)
2a82fa0 
* Fix several RPCs (#1926)

* Fix up pending receipts details.

* Add support for additional params and registry over RPC.

* Fix tests.

* Add test, additional fix.

Fixes #1932.

* Fix up tests.

* Fix test.

* Fix test.

* DB WAL size limit (#1935)

* Limit WAL size

* Check pruning by db modification date (#1924)

* Cache address hash (#1943)

* ECIES without MAC (#1948)

* Use random IV for ECIES AES

* ECIES encrypt/decrypt for a single message

* Derive IV from shared secret

* Apply settings to column families

* fixed #1933 (#1979)

* Fixed neighbours collection (#1996)

* dapps-hosts configuration

* Disabled counter check

* always process trie death row on commit, add more tracing

* fixed transaction addresses mapping, fixes #1971

* simplified iterator

* v1.3.1

* v1.3.1
@tomusdrw tomusdrw mentioned this pull request Sep 30, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavofyork @NikVolf @coveralls @arkpar