Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Make the block header struct's internals private #2000

Merged
merged 3 commits into from
Aug 29, 2016
Merged

Make the block header struct's internals private #2000

merged 3 commits into from
Aug 29, 2016

Commits on Aug 27, 2016

  1. Make the block header struct's internals private 

    Currently, this involves a lot of explicit cloning, but we
could migrate the return types of the get_* functions to
be copies rather than references since they are mostly copy
types anyway.

I opted to eliminate the constructor in favor of using
Default::default() plus calling a bunch of setters. This
is similar to the model that a Google Protobuf client uses
and I think it looks fine.
    @nipunn1313
    nipunn1313 committed Aug 27, 2016
    Configuration menu
    Copy the full SHA
    06a6d47 View commit details
    Browse the repository at this point in the history

  2. Drop some unnecessary cloning by comparing references

    @nipunn1313
    nipunn1313 committed Aug 27, 2016
    Configuration menu
    Copy the full SHA
    8678e5e View commit details
    Browse the repository at this point in the history

  3. Fix compiler errors from callsites in tests.

    @nipunn1313
    nipunn1313 committed Aug 27, 2016
    Configuration menu
    Copy the full SHA
    18c36f7 View commit details
    Browse the repository at this point in the history