Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Manually add \r to Windows phrases pre 1.4.5 #3615

Merged
merged 3 commits into from
Nov 25, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions js/src/modals/CreateAccount/RecoveryPhrase/recoveryPhrase.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
// along with Parity. If not, see <http://www.gnu.org/licenses/>.

import React, { Component, PropTypes } from 'react';
import { Checkbox } from 'material-ui';

import { Form, Input } from '../../../ui';

Expand All @@ -37,6 +38,7 @@ export default class RecoveryPhrase extends Component {
password1Error: ERRORS.invalidPassword,
password2: '',
password2Error: ERRORS.noMatchPassword,
windowsPhrase: false,
isValidPass: false,
isValidName: false,
isValidPhrase: false
Expand All @@ -47,7 +49,7 @@ export default class RecoveryPhrase extends Component {
}

render () {
const { accountName, accountNameError, passwordHint, password1, password1Error, password2, password2Error, recoveryPhrase } = this.state;
const { accountName, accountNameError, passwordHint, password1, password1Error, password2, password2Error, recoveryPhrase, windowsPhrase } = this.state;

return (
<Form>
Expand Down Expand Up @@ -86,20 +88,26 @@ export default class RecoveryPhrase extends Component {
value={ password2 }
onChange={ this.onEditPassword2 } />
</div>
<Checkbox
className={ styles.checkbox }
label='Key was created with Parity <1.4.5 on Windows'
checked={ windowsPhrase }
onCheck={ this.onToggleWindowsPhrase } />
</div>
</Form>
);
}

updateParent = () => {
const { isValidName, isValidPass, isValidPhrase, accountName, passwordHint, password1, recoveryPhrase } = this.state;
const { isValidName, isValidPass, isValidPhrase, accountName, passwordHint, password1, recoveryPhrase, windowsPhrase } = this.state;
const isValid = isValidName && isValidPass && isValidPhrase;

this.props.onChange(isValid, {
name: accountName,
passwordHint,
password: password1,
phrase: recoveryPhrase
phrase: recoveryPhrase,
windowsPhrase
});
}

Expand All @@ -109,22 +117,31 @@ export default class RecoveryPhrase extends Component {
});
}

onToggleWindowsPhrase = (event) => {
this.setState({
windowsPhrase: !this.state.windowsPhrase
}, this.updateParent);
}

onEditPhrase = (event) => {
const recoveryPhrase = event.target.value
.toLowerCase() // wordlists are lowercase
.trim() // remove whitespace at both ends
.replace(/\s/g, ' ') // replace any whitespace with single space
.replace(/ +/g, ' '); // replace multiple spaces with a single space

const parts = recoveryPhrase.split(' ');
const phraseParts = recoveryPhrase
.split(' ')
.map((part) => part.trim())
.filter((part) => part.length);
let recoveryPhraseError = null;

if (!recoveryPhrase || recoveryPhrase.length < 25 || parts.length < 8) {
if (!recoveryPhrase || recoveryPhrase.length < 25 || phraseParts.length < 8) {
recoveryPhraseError = ERRORS.noPhrase;
}

this.setState({
recoveryPhrase,
recoveryPhrase: phraseParts.join(' '),
recoveryPhraseError,
isValidPhrase: !recoveryPhraseError
}, this.updateParent);
Expand Down
5 changes: 5 additions & 0 deletions js/src/modals/CreateAccount/createAccount.css
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
/* You should have received a copy of the GNU General Public License
/* along with Parity. If not, see <http://www.gnu.org/licenses/>.
*/

.spaced {
line-height: 1.618em;
}
Expand Down Expand Up @@ -67,3 +68,7 @@
.upload>div {
margin-right: 0.5em;
}

.checkbox {
margin-top: 2em;
}
16 changes: 13 additions & 3 deletions js/src/modals/CreateAccount/createAccount.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export default class CreateAccount extends Component {
passwordHint: null,
password: null,
phrase: null,
windowsPhrase: false,
rawKey: null,
json: null,
canCreate: false,
Expand Down Expand Up @@ -200,16 +201,24 @@ export default class CreateAccount extends Component {
}

onCreate = () => {
const { createType } = this.state;
const { createType, windowsPhrase } = this.state;
const { api } = this.context;

this.setState({
canCreate: false
});

if (createType === 'fromNew' || createType === 'fromPhrase') {
let phrase = this.state.phrase;
if (createType === 'fromPhrase' && windowsPhrase) {
phrase = phrase
.split(' ') // get the words
.map((word) => word === 'misjudged' ? word : `${word}\r`) // add \r after each (except last in dict)
.join(' '); // re-create string
}

return api.parity
.newAccountFromPhrase(this.state.phrase, this.state.password)
.newAccountFromPhrase(phrase, this.state.password)
.then((address) => {
this.setState({ address });
return api.parity
Expand Down Expand Up @@ -326,14 +335,15 @@ export default class CreateAccount extends Component {
});
}

onChangeDetails = (canCreate, { name, passwordHint, address, password, phrase, rawKey }) => {
onChangeDetails = (canCreate, { name, passwordHint, address, password, phrase, rawKey, windowsPhrase }) => {
this.setState({
canCreate,
name,
passwordHint,
address,
password,
phrase,
windowsPhrase: windowsPhrase || false,
rawKey
});
}
Expand Down