This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
jsonrpc #391
Merged
jsonrpc #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
the
A3-inprogress ⏳
debris
added
A0-pleasereview 🤓
| @@ -19,6 +19,22 @@ use util::*; | |||
| use header::*; | |||
| use transaction::*; | |||
|
|
|||
| /// Uniqly identifies block in canon blockchain. | |||
There was a problem hiding this comment.
Uniquely. Also blocks from non-canon blockchain can still be identified and requested by hash
|
Looks ok to me, although it does hide some important details behind the simplified interface. Changing client interface to use |
| Hash(H256), | ||
| /// Block id and transaction index within this block. | ||
| /// Querying by block position is always faster. | ||
| BlockPosition(BlockId, usize) |
There was a problem hiding this comment.
Try to avoid using two words when one will do - Position or Location would be fine here.
gavofyork
added
A8-looksgood 🦄
|
looks fine. |
debris
added a commit
that referenced
this pull request
Feb 10, 2016
This was referenced Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
further improvements in jsonrpc
changes:
LocalizedTransaction. It contains signed transaction and info about transaction location in canon blockchain.BlockId,TransactionIdthat uniquely identifies position of block/transaction in canon blockchainquestions:
BlockIdandTransactionIdshould be defined? Right they are in views.rs, but I don't like this location.BlockIdandTransactionIdshould be destructurized? Right now it's blockchain.rs, but I don't know if it's a good place.block/block_atmethods in client.rs with one that acceptsBlockId?