This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Use secure websocket from HTTPS clients #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the unsecure `ws://` scheme is hardcoded. With this change, the scheme will dynamically change to the secure `wss://` when the frontend is requested from an HTTPS origin.
|
It looks like @skddc hasn'signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.ethcore.io Once you've signed, plesae reply to this thread with Many thanks, Ethcore CLA Bot |
|
Looks good and above-board. I just want to do a test run-through to verify. |
jacogr
added
A8-looksgood 🦄
|
[clabot:check] |
|
It looks like @skddc signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
|
Cool, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the unsecure
ws://scheme is hardcoded. With this change, the scheme will dynamically change to the securewss://when the frontend is requested from an HTTPS origin.I might have missed something, and I'm entirely new to this codebase, so please excuse me if this doesn't make sense. We just stumbled into
ws://failing for our parity node after enabling HTTPS and this is what I found as the most likely cause of the issue.