This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Disable compression for RLP strings #5786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
tomusdrw
reviewed
Jun 7, 2017
util/rlp/src/compression.rs
Outdated
| // Iterate through RLP while checking if it has been compressed. | ||
| _ => map_rlp(rlp, |r| deep_decompress(r, swapper)), | ||
| } | ||
| map_rlp(rlp, |r| deep_decompress(r, swapper)) |
There was a problem hiding this comment.
Are we sure there are no other rlps that will now fail to decompress because deep_decompress has changed?
Or will the DB resync be mandatory for everyone?
|
better just change this to |
|
lgtm |
|
What version of Parity is safe to use now? It seems that 1.4.x and 1.5.x are prone to this bug. What about 1.3.x and 1.6.x? |
|
1.6.8 Contains the fix. A re-sync is required though. Versions 1.3.0-1.6.7 are affected. |
|
@arkpar do I need to resync from the genesis, or it's enough to resync from block 3855567, which is seems to be a first block having this issue? |
|
Also, are there plans to include this fix into 1.5.x? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5779