Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Move more params to the common section. #6134

Merged
merged 3 commits into from
Jul 31, 2017
Merged

Conversation

rphmeier
Copy link
Contributor

  • gasLimitBoundDivisor
  • registrar
  • blockReward
  • eip155Transition

Also, Miner will now only seal the first block of a chain if there are no hard forks included.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 24, 2017
@keorn
Copy link

keorn commented Jul 24, 2017

Since we plan to make Parity more generic over state machines is there be a better place for those?

@rphmeier
Copy link
Contributor Author

rphmeier commented Jul 24, 2017

@keorn actually, that is the entire purpose of this PR. Now AuthorityRound and Tendermint have no configuration other than consensus-specific. CommonParams and Builtins will become part of the EthereumMachine, and engines will own only a Machine and their internal members for consensus.
To ease integration, I plan to have a blanket impl<E: Engine<EthereumMachine> + ?Sized> E { ... } in the ethcore crate.

The Ethash engine still has a bunch of its own hard forks which could also be extracted. But for now it was easier to leave them be, as we won't do much prototyping with that engine.

Eventually (perhaps before 1.8) we could change the "params" section of the spec, where CommonParams is parsed from, to configure the state machine to be used. But generalizing the infrastructure around Engine (sync, client, RPC, etc) will be much harder than generalizing Engine itself.

@keorn
Copy link

keorn commented Jul 24, 2017

True, CommonParams is mostly Ethereum specific anyway.

@arkpar arkpar added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Jul 25, 2017
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 30, 2017
@gavofyork gavofyork merged commit 003eef9 into master Jul 31, 2017
@gavofyork gavofyork deleted the more-common-params branch July 31, 2017 10:34
holiman added a commit to ethereum/hive that referenced this pull request Aug 21, 2017
5chdn added a commit that referenced this pull request Sep 21, 2017
gavofyork pushed a commit that referenced this pull request Oct 8, 2017
* Add musicoin chain spec.

* Add musicoin to parity node

* Add musicoin to the wallet

* Add i18n for musicoin

* Align musicoin chain spec with 1.8, ref #6134

* Update musicoin bootnodes

* Prepare MCIP-3 in musicoin chain spec.

* Update musicoin chain spec with contract addresses for MCIP-3

* Extend ethash params by MCIP-3

* Fix musicoin chain spec json

* Use U256 for block rewards.

* Update musicoin registrar

* Fix merge leftovers

* Update musicoin chain spec for latest master

* Bestow MCIP-3 block reward(s).

* Update musicoin registry once and for all

* Align MCIP-3 block reward with go implementation

* Remove mcip3 test chain spec from repository

* Update MCIP-3 block rewards

* Musicoin homestead transition is at 1_150_000

* Expect mcip3 transtion to be properly defined in chain spec.

* Panic handling for mcip to default to regular block rewards if not specified

* Giving mcip3 rewards a useful default value.

* Fix ethjson tests.

* Update musicoin chain spec

* Fix tests 0:)

* Add musicoin mcip3 era test spec.

* Update musicoin chain spec(s)

* Add tests for mcip3 era block rewards

* Fix tests

* Disable byzantium for musicoin

* Pass miner reward to the tracer.

* Allow modifying blockreward in MCIP-3 transition.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants