This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
do not activate genesis epoch in immediate transition validator contract #6349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
debris
added
A8-looksgood 🦄
|
From the logs it looks as though the new validator contract ABI is no longer being called. However we still have a genesis hash mismatch. |
|
Is the 1.7.x POA genesis somehow different to earlier version genesis blocks? Because of the epoch data maybe? |
|
Epoch data isn't actually included in the state, so it shouldn't be different. I'll have to investigate the differences, but AFAIK we haven't made any changes to how the genesis header is computed. |
|
|
|
I double checked my chain-spec.json and it is mostly identical to the chain-spec.json on the network. So, the genesis mismatch seems to be a real issue. |
gavofyork
added
A4-gotissues 💥
|
Could you send over your chain spec or at least one which reproduces the issue for testing? The genesis mismatch is another issue entirely. |
rphmeier
added
A8-looksgood 🦄
tomusdrw
pushed a commit
that referenced
this pull request
Sep 11, 2017
gavofyork
pushed a commit
that referenced
this pull request
Sep 11, 2017
* Fix slow balances (#6471) * Update token updates * Update token info fetching * Update logger * Minor fixes to updates and notifications for balances * Use Pubsub * Fix timeout. * Use pubsub for status. * Fix signer subscription. * Process tokens in chunks. * Fix tokens loaded by chunks * Linting * Dispatch tokens asap * Fix chunks processing. * Better filter options * Parallel log fetching. * Fix signer polling. * Fix initial block query. * Token balances updates : the right(er) way * Better tokens info fetching * Fixes in token data fetching * Only fetch what's needed (tokens) * Fix linting issues * Revert "Transaction permissioning (#6441)" This reverts commit eed0e8b. * Revert "Revert "Transaction permissioning (#6441)"" This reverts commit 8f96415. * Update wasm-tests. * Fixing balances fetching * Fix requests tracking in UI * Fix request watching * Update the Logger * PR Grumbles Fixes * PR Grumbles fixes * Linting... * eth_call returns output of contract creations (#6420) * eth_call returns output of contract creations * Fix parameters order. * Save outputs for light client as well. * Don't accept transactions above block gas limit. * Expose health status over RPC (#6274) * Node-health to a separate crate. * Initialize node_health outside of dapps. * Expose health over RPC. * Bring back 412 and fix JS. * Add health to workspace and tests. * Fix compilation without default features. * Fix borked merge. * Revert to generics to avoid virtual calls. * Fix node-health tests. * Add missing trailing comma. * Fixing/removing failing JS tests. * do not activate genesis epoch in immediate transition validator contract (#6349) * Fix memory tracing. * Add test to cover that. * ensure balances of constructor accounts are kept * test balance of spec-constructed account is kept
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6343
@mills-nick can you try with a build of this PR?