Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Gas price threshold for transactions #640

Merged
merged 5 commits into from
Mar 10, 2016
Merged

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Mar 9, 2016

  1. Threshold specified using CLI
  2. Dropping transaction from queue when it's gas_price is lower than specified threshold.

When #637 is merged new TransactionQueue specific error type should be introduced.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Mar 9, 2016
@@ -108,6 +108,7 @@ API and Console Options:
--rpccorsdomain URL Equivalent to --jsonrpc-cors URL (geth-compatible).

Sealing/Mining Options:
--gasprice GAS Minimal gas price a transaction must have to be accepted for mining [default: 50000000000].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this in keeping with geth?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Taken from geth@1.3.3. Will check on 1.4 in the morning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 20kkk (geth@1.3.5)

@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. A8-looksgood 🦄 Pull request is reviewed well. A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Mar 9, 2016
@tomusdrw tomusdrw removed the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Mar 10, 2016
@tomusdrw
Copy link
Collaborator Author

Note it should be merged before #653

@tomusdrw tomusdrw mentioned this pull request Mar 10, 2016
gavofyork added a commit that referenced this pull request Mar 10, 2016
Gas price threshold for transactions
@gavofyork gavofyork merged commit cd37fa7 into ethminer_crate Mar 10, 2016
@gavofyork gavofyork deleted the tx_queue_min_gas branch March 10, 2016 10:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants