This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
JournalDB -> Box<JournalDB>, and it's a trait. #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,22 +47,12 @@ use std::env; | |||
| /// write operations out to disk. Unlike OverlayDB, `remove()` operations do not take effect | |||
| /// immediately. Rather some age (based on a linear but arbitrary metric) must pass before | |||
| /// the removals actually take effect. | |||
| pub struct JournalDB { | |||
| pub struct OptionOneDB { | |||
There was a problem hiding this comment.
Is it possible to give it some more descriptive name?
There was a problem hiding this comment.
it's possible... but i'm not sure what that would be. we've always referred to the algorithm as "option one".
tomusdrw
added
A8-looksgood 🦄
| @@ -36,6 +36,7 @@ use kvdb::{Database}; | |||
| /// | |||
| /// `lookup()` and `contains()` maintain normal behaviour - all `insert()` and `remove()` | |||
| /// queries have an immediate effect in terms of these functions. | |||
| #[derive(Clone)] | |||
tomusdrw
added
A5-grumble 🔥
gavofyork
added
A0-pleasereview 🤓
tomusdrw
added
A8-looksgood 🦄
NikVolf
added a commit
that referenced
this pull request
Mar 11, 2016
JournalDB -> Box<JournalDB>, and it's a trait.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.